Merge pull request #1062 from pinterest/render-pin

Fixing embedded pin render issues
ampproject · Dec 10, 2015 · 5d8b894 · 5d8b894
2 parents 3b050ea + cb31da4
commit 5d8b894
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/extensions/amp-pinterest/0.1/amp-pinterest.js b/extensions/amp-pinterest/0.1/amp-pinterest.js
@@ -180,7 +180,7 @@ class AmpPinterest extends AMP.BaseElement {
 
       const structure = make({'span': {}});
 
-      const renderPin = function(r) {
+      const renderPin = function(self, r) {
 
         if (r && r.data && r.data[0] && !r.data[0].error) {
           const p = r.data[0];
@@ -338,19 +338,19 @@ class AmpPinterest extends AMP.BaseElement {
           });
 
           // fill it
-          this.applyFillContent(structure);
+          self.applyFillContent(structure);
           // append it
-          this.element.appendChild(structure);
+          self.element.appendChild(structure);
           // done
-          return loadPromise(img);
+          return loadPromise(structure);
         }
       };
 
       const query = 'https://widgets.pinterest.com/v3/pidgets/pins/info/' +
         '?pin_ids=' + pinId +
         '&sub=www&base_scheme=https';
       return call(query).then(r => {
-        return renderPin(r);
+        return renderPin(this, r);
       });
     };
 

diff --git a/extensions/amp-pinterest/amp-pinterest.md b/extensions/amp-pinterest/amp-pinterest.md
@@ -50,7 +50,7 @@ Required when `data-do` is `buttonPin`.  Contains the fully-qualified URL of the
 
 Required when `data-do` is `buttonPin`.  Contains the default description that appears in the pin create form; please choose carefully, since many Pinners will close the form without pinning if it doesn't make sense.
 
-### Iframe Sizing for the Pin It Button
+### Sizing the Pin It Button
 
 Default small rectangular button: