Skip to content

Commit

Permalink
Refactor amp-ad into extension (#2902)
Browse files Browse the repository at this point in the history
* Factor amp-ad into extension
  • Loading branch information
zhouyx committed May 16, 2016
1 parent 3662221 commit 1dd0d74
Show file tree
Hide file tree
Showing 20 changed files with 1,558 additions and 483 deletions.
7 changes: 7 additions & 0 deletions build-system/tasks/presubmit-checks.js
Original file line number Diff line number Diff line change
Expand Up @@ -421,6 +421,13 @@ var forbiddenTermsSrcInclusive = {
'\\.webkitConvertPointFromPageToNode(?!_)': bannedTermsHelpString,
'\\.changeHeight(?!_)': bannedTermsHelpString,
'\\.changeSize(?!_)': bannedTermsHelpString,
'insertAmpExtensionScript': {
message: bannedTermsHelpString,
whitelist: [
'src/insert-extension.js',
'src/element-stub.js',
],
},
'reject\\(\\)': {
message: 'Always supply a reason in rejections. ' +
'error.cancellation() may be applicable.',
Expand Down
Loading

0 comments on commit 1dd0d74

Please sign in to comment.