Let whitelist sanitizer dictate the required AMP scripts via spec #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use spec to determine which script components get enqueued * Use the latest component instead of 0.1 * Reduce duplicated logic by defining get_scripts() method on base sanitizer * Add get_allowed_tag_data method on AMP_Allowed_Tags_Generated to reduce size of array passing. * Define sanitized_tag class variable on sanitizer classes
Include also_requires_tag_warning in AMP_Allowed_Tags_Generated
…now handles discovery
Now the scripts are obtained via the whitelist sanitizer alone, so there is no need for the redundancy of obtaining the component scripts via the individual sanitizers or to duplicate the component lookup via a get_allowed_tag_data method.
westonruter
changed the title
|
@westonruter how about running the embeds through the |
ThierryA
approved these changes
Jan 19, 2018
There was a problem hiding this comment.
Awesome work on this, bang on! I am merging this so that @DavidCramer can use it in #871.
This comment may be implemented in another PR if we decide to go with it.
|
Sweet! |
Excellent point. The embeds don't need to implement |
This was referenced Jan 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires_extensionandalso_requires_tag_warningfrom spec inAMP_Allowed_Tags_Generatedso that the required AMP components can be determined for a given tag spec and returned viaAMP_Tag_And_Attribute_Sanitizer::get_scripts().latestversions of AMP component scripts instead of0.1. (Discussed with @amedina.)get_scripts()method implementations from all of the sanitizers since all of the scripts now identified by whitelist sanitizer.AMP_Theme_Support::get_amp_component_scripts().With the changes here, you can just drop in AMP components to your post content (or to the theme templates w/ theme support) and AMP component scripts will automatically be added for them. For example, try pasting the following into a new post:
<amp-gist data-gistid="b9bb35bc68df68259af94430f012425f" layout="fixed-height" height="225"> </amp-gist> <amp-ad type="a9" width="300" height="250" data-aax_size="300x250" data-aax_pubname="test123" data-aax_src="302"> </amp-ad>Automatically you'll then see these scripts added to the
head:<script custom-element="amp-video" src="https://cdn.ampproject.org/v0/amp-video-latest.js" async></script><script custom-element="amp-gist" src="https://cdn.ampproject.org/v0/amp-gist-latest.js" async></script>See #875.