Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update paired browsing script dependencies array #7596

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Update paired browsing script dependencies array #7596

merged 2 commits into from
Aug 3, 2023

Conversation

thelovekesh
Copy link
Collaborator

Summary

Fixes #7595

Checklist

PairedBrowsing depends on the wp-dom-ready script which requires:

  • wp-polyfill
    • wp-polyfill-inert
    • regenerator-runtime

This PR updates the paired browsing script dependencies array.

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@thelovekesh thelovekesh requested a review from westonruter August 2, 2023 20:23
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023 •
edited
Loading

Plugin builds for 533d73d are ready 🛎️!

@thelovekesh thelovekesh force-pushed the add/wp-inert-polyfill-in-amp-devmode branch from f3c49b6 to 533d73d Compare August 2, 2023 20:34
westonruter
westonruter approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @milindmore22 Would you test?

@milindmore22
Copy link
Collaborator

Tested build, issues seems fixed.

Tested on Standard, Transitional, Reader Mode with Reader Mode Theme, and Legacy Theme

@thelovekesh thelovekesh marked this pull request as draft August 3, 2023 14:10
@thelovekesh thelovekesh marked this pull request as ready for review August 3, 2023 14:10
@westonruter westonruter added this to the v2.4.3 milestone Aug 3, 2023
@westonruter westonruter merged commit d421f58 into develop Aug 3, 2023
@westonruter westonruter deleted the add/wp-inert-polyfill-in-amp-devmode branch August 3, 2023 16:01
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

@milindmore22 milindmore22 Awaiting requested review from milindmore22

Assignees
No one assigned
Labels
Changelogged Whether the issue/PR has been added to release notes.
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging this pull request may close these issues.

wp-polyfill-inert missing data-ampdevmode attribute
3 participants
@thelovekesh @milindmore22 @westonruter