Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple build process from packaging process #7144

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

thelovekesh
Copy link
Collaborator

@thelovekesh thelovekesh commented Jun 10, 2022

Summary

Decoupled plugin zip process from the build process and update the packaging command in the workflow.

  • On running npm run build:(dev|prod) it will execute the following according to NODE_ENV:
"build:dev": "cross-env NODE_ENV=development npm-run-all 'build:!(dev|prod)'",
"build:prod": "cross-env NODE_ENV=production npm-run-all 'build:!(dev|prod)'",
"build:prepare": "grunt clean",
"build:js": "wp-scripts build"
  • On running npm run package:(dev|prod) it will execute the following commands:
"package:dev": "npm-run-all build:dev 'package:!(dev|prod)'",
"package:prod": "npm-run-all build:prod 'package:!(dev|prod)'",
"package:run": "grunt build",
"package:zip": "grunt create-build-zip"

Fixes #3302

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@thelovekesh thelovekesh requested a review from milindmore22 June 10, 2022 13:16
@github-actions
Copy link
Contributor

github-actions bot commented Jun 10, 2022

Plugin builds for 1862247 are ready 🛎️!

@thelovekesh thelovekesh self-assigned this Jun 10, 2022
@thelovekesh thelovekesh force-pushed the enhancement/decouple-build-and-plugin-zip branch from de8d625 to 1862247 Compare June 11, 2022 07:43
Copy link
Collaborator

@milindmore22 milindmore22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@westonruter westonruter merged commit ff8615e into develop Jun 15, 2022
@westonruter westonruter deleted the enhancement/decouple-build-and-plugin-zip branch June 15, 2022 21:11
@westonruter westonruter added this to the v2.3.1 milestone Jun 15, 2022
@westonruter westonruter modified the milestones: v2.3.1, v2.4 Jan 26, 2023
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelogged Whether the issue/PR has been added to release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decouple build process from packaging process
3 participants