Add plugin suppression info in plugins screen #6959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Plugin builds for 73ce94c are ready 🛎️!
|
delawski
requested changes
Mar 8, 2022
There was a problem hiding this comment.
@dhaval-parekh Thanks for the PR.
I noticed an issue with this feature on a multisite install. The network Plugins screen (/wp-admin/network/plugins.php) incorrectly displays an information about plugin suppression (it uses suppression data for the main site in a network):
I think we skip displaying this information in the network dashboard since plugin suppression is site-specific.
westonruter
requested changes
Mar 8, 2022
dhaval-parekh
force-pushed
the
feature/5340-plugin-suppression-into-plugins-screen
branch
from
621839b to
715fd43
Compare
westonruter
reviewed
Mar 9, 2022
src/PluginSuppression.php
Outdated
|
|
||
| $screen = get_current_screen(); | ||
|
|
||
| if ( ! ( $screen instanceof WP_Screen && 'plugins' === $screen->id ) ) { |
There was a problem hiding this comment.
What was this needed for? Wouldn't the plugin_row_meta filter only be shown on the plugins screen anyway?
There was a problem hiding this comment.
I guess for @delawski's comment in #6959 (review)?
…340-plugin-suppression-into-plugins-screen * 'develop' of github.com:ampproject/amp-wp: Copy referrerpolicy attribute from img to amp-pixel Improve nav menu E2E tests by creating test menu before each test suite Bail out if there is no menu location or it is already selected Add E2E tests for Twenty Twenty-Two header nav menu block Test Twenty Twenty search modal on mobile breakpoint Remove redundant space Use `Extension` class constant for getting `amp-pixel` tag name Add missing replacement string to `str_replace` and reformat Use `::class` constant instead of hardcoded class name Examine parsed URL instead of using regex Remove `amp-pixel` from selector conversion mapping Replace `img` with `amp-pixel` when dealing with Facebook tracking pixel
…ency with PluginRegistry
westonruter
reviewed
Mar 9, 2022
src/PluginSuppression.php
Outdated
Comment on lines
507
to
509
| $screen = get_current_screen(); | ||
|
|
||
| if ( ! ( $screen instanceof WP_Screen && 'plugins' === $screen->id ) ) { |
There was a problem hiding this comment.
If so, another option would be:
Suggested change
| $screen = get_current_screen(); | |
| if ( ! ( $screen instanceof WP_Screen && 'plugins' === $screen->id ) ) { | |
| if ( is_network_admin() ) { |
westonruter
reviewed
Mar 10, 2022
westonruter
approved these changes
Mar 10, 2022
westonruter
deleted the
feature/5340-plugin-suppression-into-plugins-screen
branch
westonruter
changed the title
westonruter
changed the title
westonruter
added a commit
that referenced
this pull request
Mar 10, 2022
Co-authored-by: Dhaval Parekh <dmparekh007@gmail.com>
westonruter
added
the
Changelogged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5340
Add plugin suppression info in the plugin meta row on the plugin screen.
Checklist