Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert #6952 and bump @wordpress/scripts to 22.1.0 #6955

Merged
merged 2 commits into from
Mar 3, 2022
Merged

Revert #6952 and bump @wordpress/scripts to 22.1.0 #6955

merged 2 commits into from
Mar 3, 2022

Conversation

delawski
Copy link
Collaborator

@delawski delawski commented Mar 3, 2022 •
edited by westonruter
Loading

Summary

Fixes #6952
Fixes #6947

Revert #6952 and bump @wordpress/scripts to 22.1.0. This will prevent copying PHP files from src/ to assets/ directory.

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

delawski added 2 commits March 3, 2022 17:24
@delawski
Revert "Prevent copying PHP files from src/ into assets/"
10d3161 
This reverts commit 78e0341.
@delawski
Bump @wordpress/scripts to 22.1.0
90902e7 
This will prevent copying PHP files from `src/` to `assets/` directory.
@delawski delawski added Bug Something isn't working Infrastructure Changes impacting testing infrastructure or build tooling labels Mar 3, 2022
@delawski delawski added this to the v2.2.2 milestone Mar 3, 2022
@delawski delawski requested a review from westonruter March 3, 2022 16:29
@delawski delawski self-assigned this Mar 3, 2022
@delawski delawski mentioned this pull request Mar 3, 2022
Closed
westonruter
westonruter reviewed Mar 3, 2022
View reviewed changes
package.json
@@ -60,7 +60,7 @@
"@wordpress/hooks": "3.3.1",
"@wordpress/jest-puppeteer-axe": "4.0.1",
"@wordpress/plugins": "4.1.3",
"@wordpress/scripts": "22.0.1",
"@wordpress/scripts": "22.1.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this includes WordPress/gutenberg#39171 and since --webpack-copy-php is not present the PHP files won't be copied.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2022

Plugin builds for 90902e7 are ready 🛎️!

@delawski
Copy link
Collaborator Author

delawski commented Mar 3, 2022

I've just checked if the development build contains any PHP files in the assets/ directory and it doesn't:

Screenshot 2022-03-03 at 17 47 25

@westonruter westonruter merged commit 7b7fde8 into develop Mar 3, 2022
@westonruter westonruter deleted the fix/6947-prevent-webpack-from-copying-php branch March 3, 2022 16:50
westonruter added a commit that referenced this pull request Mar 3, 2022
@westonruter @delawski
Revert #6952 and bump @wordpress/scripts to 22.1.0 (#6955)
9652584 
Also cherry-picks #6953

Co-authored-by: Piotr Delawski <piotr.delawski@gmail.com>
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter left review comments

Assignees

@delawski delawski

Labels
Bug Something isn't working Changelogged Whether the issue/PR has been added to release notes. Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Milestone
v2.2.2
Development

Successfully merging this pull request may close these issues.

PHP files are being copied from src/ into assets/
2 participants
@delawski @westonruter