Immediately add/remove DevTools-related AMP admin menu items when setting updated #6878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show/Hides Developer Tools in WP AMP menu section when Enable Developer tools is toggled and saved
NikhilJoshua
force-pushed
the
bug/6714-show-hide-devtools-on-save
branch
from
d878740 to
32233f8
Compare
dhaval-parekh
approved these changes
Feb 25, 2022
…show-hide-devtools-on-save * 'develop' of github.com:ampproject/amp-wp: (125 commits) Bump postcss-preset-env from 7.4.1 to 7.4.2 Update namespace for Attribute and Tag interfaces Remove obsolete debug code Defer creation of post fixture until test Add assertion for post data being created before test Add yet more assertions to debug oEmbed problem on GHA Add oembed_request_post_id filter sooner Add more assertions Add assertions Ensure video shortcode is registered to test_process_text_widgets Use oembed_request_post_id for test Add debugging code Fix test_add_block_source_comments for Gutenberg 12.7 Add missing HTTP response mock Add tests for internal post embeds Prevent copying PHP files from `src/` into `assets/` Bump actions/checkout from 2 to 3 Bump eslint-plugin-jsdoc from 37.9.5 to 37.9.6 Update since tag to 2.2.2 Bump eslint-plugin-jsdoc from 37.9.4 to 37.9.5 ...
…em matching more robust
westonruter
requested changes
Mar 3, 2022
assets/src/settings-page/index.js
Outdated
Comment on lines
164
to
181
| /* | ||
| * Adds the developer tools 'Validated URLs' & 'Error Index' on turning ON | ||
| * the 'Enable Developer Tools' toggle button and saving. | ||
| */ | ||
| const addAmpDevOptions = ( optionTitle, optionUrl ) => { | ||
| const wpAmpSettings = document.querySelector( '#toplevel_page_amp-options ul' ); | ||
|
|
||
| if ( wpAmpSettings === null ) { | ||
| return; | ||
| } | ||
|
|
||
| const listElement = document.createElement( 'li' ); | ||
| const anchorElement = document.createElement( 'a' ); | ||
| anchorElement.innerText = optionTitle; | ||
| anchorElement.setAttribute( 'href', optionUrl ); | ||
| listElement.appendChild( anchorElement ); | ||
| wpAmpSettings.appendChild( listElement ); | ||
| }; |
There was a problem hiding this comment.
This would make sense to be defined at the top level of the module, rather than as a nested callback.
assets/src/settings-page/index.js
Outdated
| return; | ||
| } | ||
|
|
||
| addAmpDevOptions( __( 'Validated URLs', 'amp' ), 'edit.php?post_type=amp_validated_url' ); |
There was a problem hiding this comment.
The URL here is actually already exported as part of amp-settings as VALIDATED_URLS_LINK.
assets/src/settings-page/index.js
Outdated
| } | ||
|
|
||
| addAmpDevOptions( __( 'Validated URLs', 'amp' ), 'edit.php?post_type=amp_validated_url' ); | ||
| addAmpDevOptions( __( 'Error Index', 'amp' ), 'edit-tags.php?taxonomy=amp_validation_error&post_type=amp_validated_url' ); |
There was a problem hiding this comment.
To go along with the previous, we could add ERROR_INDEX_LINK as exported from PHP.
assets/src/settings-page/index.js
Outdated
| * Add/Remove Dev Tools 'Validated URLs' & 'Error Index' on 'Enable Developer Tools' ON/OFF on save. | ||
| */ | ||
| if ( ! developerToolsOption ) { | ||
| document.querySelectorAll( '#toplevel_page_amp-options ul li a[href*="post_type=amp_validated_url"]' ) |
There was a problem hiding this comment.
While this works, it seems it could be hardened a bit to prevent removing unexpected menu items.
|
I apologize for my delay in reviewing. Please take a look at my suggested changes in 41dac1d. |
Thanks for the updates/changes :) @westonruter |
westonruter
approved these changes
Mar 3, 2022
westonruter
changed the title
westonruter
changed the title
westonruter
added a commit
that referenced
this pull request
Mar 3, 2022
…ting updated (#6878) Co-authored-by: Nikhil Joshua <nikhiljoshua.a@gmail.com>
westonruter
added
the
Changelogged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6714
These changes will add or remove "Validated URL" and "Error Index" menu items from the main AMP menu when the user changes the "Enable Developer Tool" option and save it instead of adding or removing it after page load.
screen-capture.mp4
Checklist