Code

Improve page cache detection test#6849

Code

Merged

westonruter merged 35 commits intodevelopampproject/amp-wp:developfrom bug/6830-page-cache-detectionampproject/amp-wp:bug/6830-page-cache-detectionCopy head branch name to clipboardJan 28, 2022

+534-114

Commits

Commits on Jan 28, 2022

• Update logic to detect page cache

  

  dhaval-parekh

  authored and

  delawski

  committed
  776e0e0

  Copy full SHA for 776e0e0

• Change function name from SiteHealth::has_page_caching() to SiteHealth::get_page_cache_status()

  

  dhaval-parekh

  authored and

  delawski

  committed
  b21531c

  Copy full SHA for b21531c

• Update logic condition in SiteHealth::persistent_object_cache()

  

  dhaval-parekh

  authored and

  delawski

  committed
  945df6a

  Copy full SHA for 945df6a

• Update unit test case

  

  dhaval-parekh

  authored and

  delawski

  committed
  9641968

  Copy full SHA for 9641968

• Update logic to check page caching

  

  dhaval-parekh

  authored and

  delawski

  committed
  bc8c64f

  Copy full SHA for bc8c64f

• Add more unit test cases for page cacheing detection

  

  dhaval-parekh

  authored and

  delawski

  committed
  e7068fb

  Copy full SHA for e7068fb

• Update the logic to get page cache status

  

  dhaval-parekh

  authored and

  delawski

  committed
  33e4acf

  Copy full SHA for 33e4acf

• Update list of header to detect page cache

  

  dhaval-parekh

  authored and

  delawski

  committed
  d0dff7f

  Copy full SHA for d0dff7f

• Add support of legacy transient value

  

  dhaval-parekh

  authored and

  delawski

  committed
  5965a93

  Copy full SHA for 5965a93

• Add unit test cases

  

  dhaval-parekh

  authored and

  delawski

  committed
  4a445c3

  Copy full SHA for 4a445c3

• Apply suggestions from PR

  

  dhaval-parekh

  authored and

  delawski

  committed
  abab8c8

  Copy full SHA for abab8c8

• Added more detail in page cache test description

  

  dhaval-parekh

  authored and

  delawski

  committed
  ebea985

  Copy full SHA for ebea985

• Update unit test cases

  

  dhaval-parekh

  authored and

  delawski

  committed
  fb32dde

  Copy full SHA for fb32dde

• Improve strings in site health test

  

  westonruter

  authored and

  delawski

  committed
  e426aad

  Copy full SHA for e426aad

• Opt to disregard legacy cached value

  

  westonruter

  authored and

  delawski

  committed
  3e1b6e1

  Copy full SHA for 3e1b6e1

• Allow good response time theshold to be filtered

  

  westonruter

  authored and

  delawski

  committed
  4d16ca7

  Copy full SHA for 4d16ca7

• Only show lack of page caching plugin if no caching response headers present

  

  westonruter

  authored and

  delawski

  committed
  f590d79

  Copy full SHA for f590d79

• Speed up tests by using usleep() instead of sleep()

  

  westonruter

  authored and

  delawski

  committed
  71dba7e

  Copy full SHA for 71dba7e

• Simplify translation string

  

  westonruter

  authored and

  delawski

  committed
  3d42202

  Copy full SHA for 3d42202

• Improve test coverage and simplify conditional

  

  westonruter

  authored and

  delawski

  committed
  27e9f9b

  Copy full SHA for 27e9f9b

• Add formatting for millisecond values

  

  westonruter

  authored and

  delawski

  committed
  ea62544

  Copy full SHA for ea62544

• Fix label when page caching detected and yet response still slow

  

  westonruter

  authored and

  delawski

  committed
  df79c74

  Copy full SHA for df79c74

• Remove erroneous P from wrapping UL

  

  westonruter

  authored and

  delawski

  committed
  a1ab983

  Copy full SHA for a1ab983

• Reuse threshold variable

  

  westonruter

  authored and

  delawski

  committed
  e0207ae

  Copy full SHA for e0207ae

• Simplify logic in get_page_cache_detail

  

  westonruter

  authored and

  delawski

  committed
  bab5122

  Copy full SHA for bab5122

• Scope styles for dashicons

  

  westonruter

  authored and

  delawski

  committed
  bfdaba5

  Copy full SHA for bfdaba5

• Remove debug code for catching external requests

  

  westonruter

  authored and

  delawski

  committed
  b5da0e1

  Copy full SHA for b5da0e1

• Refine comments

  

  westonruter

  authored and

  delawski

  committed
  f4068a1

  Copy full SHA for f4068a1

• Remove redundant checks for header value being non-empty

  

  westonruter

  authored and

  delawski

  committed
  8acc63e

  Copy full SHA for 8acc63e

• Improve strings and comments

  

  westonruter

  authored and

  delawski

  committed
  4735819

  Copy full SHA for 4735819

• Use different selector in E2E test

  delawski

  committed
  90d9a16

  Copy full SHA for 90d9a16

• Ensure AMP plugin is activated before running E2E tests

  delawski

  committed
  4a4c490

  Copy full SHA for 4a4c490

• Ensure get_page_cache_detail return value is array

  westonruter

  committed
  188e0cd

  Copy full SHA for 188e0cd

• Revert "Ensure AMP plugin is activated before running E2E tests"

  Show description for e763783
  westonruter

  committed
  e763783

  Copy full SHA for e763783

• Revert "Use different selector in E2E test"

  Show description for 1d25cc4
  westonruter

  committed
  1d25cc4

  Copy full SHA for 1d25cc4