Optimize the process of deleting AMP data during uninstallation #6840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Plugin builds for ab388a3 are ready 🛎️!
|
dhaval-parekh
changed the title
westonruter
reviewed
Jan 18, 2022
westonruter
reviewed
Jan 19, 2022
dhaval-parekh
force-pushed
the
bug/6826-delete-data-while-uninstalling
branch
from
a956171 to
25e2337
Compare
|
The broken unit test case is not related to changes in the current PR. |
dhaval-parekh
force-pushed
the
bug/6826-delete-data-while-uninstalling
branch
from
1dece18 to
cf26652
Compare
This has been addressed 825a555 by Weston |
|
For the sake of being exceedingly careful, I've added tests for each uninstall function to check that they individually are behaving as expected. So we have basically two sets of tests now that are checking and re-checking that uninstall is removing only the expected data and leaving everything else as-is. |
westonruter
approved these changes
Jan 25, 2022
westonruter
changed the title
westonruter
added a commit
that referenced
this pull request
Jan 25, 2022
westonruter
added
the
Changelogged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6826
This PR optimized the process of deleting AMP data during uninstallation. Instead of deleting posts and terms one by one with the WordPress function, it will run the DELETE query directly to the database to delete records.
Checklist