Ampify responsive Navigation Block #6838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
delawski
added
Enhancement
|
Plugin builds for 95a3405 are ready 🛎️!
|
dhaval-parekh
approved these changes
Jan 21, 2022
…319-ampify-wp-navigation-block * 'develop' of github.com:ampproject/amp-wp: (26 commits) Fix indentation Add assertions that no SQL queries run when data deletion is disabled Add test specifically for transient deletion Harden term deletion logic for WP<4.4 Add assertions for term deletion Flesh out tests specifically for post and term deletion Add test specific to delete_user_metadata Add test specifically for the delete_options function Remove deletion of non-option Add test assertions for terms table Use constant for taxonomy slug in test Add formatting for SQL statements Normalize config.allow-plugins in composer.json Update database queries to delete data during uninstalltion Revert changes from delete_user_metadata() Use delete queries instead of WP function to delete posts and term during uninstalltion Add more unit test cases for uninstall.php Render value as fallback instead of entire parent source object Fix logic inversion for sources.length Ensure `sources` is non-empty array ...
…ne if test should be skipped
westonruter
approved these changes
Jan 25, 2022
westonruter
added a commit
that referenced
this pull request
Jan 25, 2022
westonruter
added
the
Changelogged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6319
Closes #6744
This PR adds AMP support to the new Responsive Navigation block.
The key differences to the another solution proposed in #6744 are:
amp-bindis used for toggling the appropriate class names and ARIA attributes (it replaces themicromodallogic from the original implementation).amp-lightboxoramp-sidebaris used.AMP_Core_Block_Handler::ampify_navigation_blockno DOM tree manipulation is performed (only plain strings replacements).When testing, it's important to use a menu that has at least one submenu (preferably more). It's because the submenus have their own toggle logic, independent of the overlay menu setting.
Checklist