Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated controls from editor sidebar and fix AMP Lightbox and AMP Carousel in Gallery block #6833

Merged
merged 18 commits into from
Jan 29, 2022
Merged

Remove deprecated controls from editor sidebar and fix AMP Lightbox and AMP Carousel in Gallery block #6833

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
8992aeb
Remove `ampLayout` and `ampNoLoading` controls from block editor
delawski Jan 13, 2022
ddfd6bd
Don't show AMP Lightbox toggle for image blocks nested in gallery blocks
delawski Jan 13, 2022
1f84d5a
Add `data-amp-lightbox` attr to image blocks nested in gallery blocks
delawski Jan 13, 2022
25648a4
Remove obsolete unit test
delawski Jan 13, 2022
b74a4c6
Fix phpcs issues
delawski Jan 13, 2022
7e3fb33
Ensure legacy gallery blocks and empty galleries are skipped
delawski Jan 20, 2022
ee55b7e
Fix and update phpunit tests
delawski Jan 20, 2022
b209296
Merge branch 'develop' of github.com:ampproject/amp-wp into fix/edito…
westonruter Jan 22, 2022
9e9d197
Merge branch 'develop' of github.com:ampproject/amp-wp into fix/edito…
westonruter Jan 26, 2022
bc32f7d
Work around test failures in WP 5.0 and 5.1 when data-id attribute wa…
westonruter Jan 27, 2022
6271ffc
Add support turning new Gallery block markup into carousel
westonruter Jan 24, 2022
235bc1f
Remove extraneous space
westonruter Jan 27, 2022
920eaa1
Fix erroneous source/expected data in block sanitizer test cases
westonruter Jan 28, 2022
cf02496
Merge branch 'develop' of github.com:ampproject/amp-wp into fix/edito…
westonruter Jan 28, 2022
d28e04a
Remove extraneous capture group
westonruter Jan 28, 2022
6618b64
Remove unused PHP import for Document class
westonruter Jan 28, 2022
65065df
Add ampCarousel to propTypes
westonruter Jan 29, 2022
83f143c
Fix rendering of carousel with gallery block having nested images
westonruter Jan 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions assets/src/block-editor/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,4 @@ export const TEXT_BLOCKS = [
'core/subhead',
];

export const MEDIA_BLOCKS = [
'core/image',
'core/video',
];

export const DEFAULT_WIDTH = 608; // Max-width in the editor.
export const DEFAULT_HEIGHT = 400;

export const POST_PREVIEW_CLASS = 'editor-post-preview';
Loading