Replace amp_experimental_sandboxing_enabled filter with Sandboxing experiment toggle
#6757
Conversation
|
Plugin builds for 4d75dc2 are ready 🛎️!
|
|
I have tested this on the staging and it is working fine. 👍 |
| theme_support: themeSupport, | ||
| } } = useContext( Options ); | ||
|
|
||
| if ( STANDARD !== themeSupport ) { |
There was a problem hiding this comment.
Since this is an experimental feature, should it be available to technical users only?
There was a problem hiding this comment.
That's a good question. I think that it should be available to non-technical users too, as this feature is intended to be the most benefit to users who are not technical in the first place, since it avoids the need to fix validation errors.
Co-authored-by: Piotr Delawski <delawski@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
…ndboxing-filter-opt-in * 'develop' of github.com:ampproject/amp-wp: (28 commits) Fix test after message update in 3a5f4aa Improve phpdoc comments and guard against JSON parse error for post_content Translate error message when failing to send to insights server Remove unused REST API endpoint Further reuse amp_validated_post variable Sanitize value of query param before using Apply suggestion from PR Prevent multiple support request in case of error Add test case for SupportScreen::get_amp_validated_post_counts() Update function docs. Use AMP_Validated_URL_Post_Type::get_invalid_url_post() instead of post_exists() Clear timeout correctly Simplify the E2E test Simplify logic for ensuring consistent units Propagate more styles AMP-valid dimensions to AMP element Add tests for deriving width/height from styles Propagate width/height styles as width/height attributes when setting layout Fix typo in Sandboxinf level drawer Use plural nouns in variable name Fetch only amp_validated_url post that have error on support page Update prop types ...
| @@ -289,7 +289,7 @@ | |||
| "packages-dev": [ | |||
| { | |||
| "name": "ampproject/php-css-parser-install-plugin", | |||
| "version": "dev-develop", | |||
| "version": "dev-remove/sandboxing-filter-opt-in", | |||
There was a problem hiding this comment.
This line, changed by the ergebnis/composer-normalize, looked a bit suspicious to me. However, I did a fresh install of the plugin from the repo and everything seems to be working fine.
There was a problem hiding this comment.
Yeah, this seems to always happen whenever doing composer install from a different branch.
|
QA Passed
The sandbox functionality is working as expected |
westonruter
added
the
Changelogged
Summary
Previously in order to enable the Sandboxing experiment, a mini plugin would have to be added that does:
This added undue friction to test the feature. So the filter has been removed in favor of a checkbox:
When checked, the sandboxing level radio buttons appear:
The drawer has also been moved down to be right before Other instead of being the first among the Advanced Settings.
Checklist