Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Contact Form 7 instead of Autoptimize or Akismet for AMP-incompatible plugin in E2E tests #6751

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

westonruter
Copy link
Member

This is a follow-up to b69d826 in #6745.

@github-actions
Copy link
Contributor

Plugin builds for d0da168 are ready 🛎️!

@westonruter westonruter changed the title Use Contact Form 7 instead of Autoptimize for AMP-incompatible plugin in E2E tests Use Contact Form 7 instead of Autoptimize or Akismet for AMP-incompatible plugin in E2E tests Nov 30, 2021
@westonruter
Copy link
Member Author

Note that Autoptimize had some PHP notices being triggered as seen in this test run: https://github.com/ampproject/amp-wp/runs/4362525476?check_suite_focus=true

I tried switching to Akismet but I did so incompletely, and I needed to pick an AMP-incompatible plugin instead. (Akismet is AMP-compatible)

image

@westonruter westonruter added the Infrastructure Changes impacting testing infrastructure or build tooling label Nov 30, 2021
@westonruter westonruter added this to the v2.2 milestone Nov 30, 2021
@westonruter westonruter merged commit e24bbac into develop Nov 30, 2021
@westonruter westonruter deleted the update/e2e-amp-incompatible-plugin branch November 30, 2021 04:21
@westonruter westonruter mentioned this pull request Nov 30, 2021
2 tasks
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelogged Whether the issue/PR has been added to release notes. Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant