Implement WP 5.9 change to remove empty query string when removing endpoint from a URL that contains a URL fragment #6727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
Plugin builds for fb82dcc are ready 🛎️!
|
westonruter
added a commit
that referenced
this pull request
Nov 17, 2021
westonruter
changed the title
test_amp_remove_paired_endpoint in WP 5.9 by removing empty query string
westonruter
added
the
Changelogged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
remove_query_arg()function before WP 5.9 would end up leaving?#when all query vars were removed. This implements the core change in 5.9 to strip out that extraneous?in older versions as well.See https://core.trac.wordpress.org/ticket/44499
Checklist