Code

Add Site Scan Feature#6610

Code

Merged

westonruter merged 122 commits intodevelopampproject/amp-wp:developfrom feature/4719-site-scanampproject/amp-wp:feature/4719-site-scanCopy head branch name to clipboardOct 28, 2021

+4,377-942

Commits

Commits on Oct 25, 2021

• Add Site Scan step bare bones to Onboarding Wizard

  

  delawski

  authored and

  westonruter

  committed
  1e6878f

  Copy full SHA for 1e6878f

• Add ProgressBar component

  

  delawski

  authored and

  westonruter

  committed
  79af03d

  Copy full SHA for 79af03d

• Move SiteScanContextProvider to common components folder

  

  delawski

  authored and

  westonruter

  committed
  4bd7a32

  Copy full SHA for 4bd7a32

• Add amp/v1/scannable-urls REST endpoint

  

  delawski

  authored and

  westonruter

  committed
  df37573

  Copy full SHA for df37573

• Refactor validation endpoint to allow validating by URL

  

  delawski

  authored and

  westonruter

  committed
  b84e7b0

  Copy full SHA for b84e7b0

• Apply suggestions from code review

  Show description for 241e1b8
  

  delawski

  and

  westonruter

  committed
  241e1b8

  Copy full SHA for 241e1b8

• Revert "Refactor validation endpoint to allow validating by URL"

  Show description for 5bd0575
  

  delawski

  authored and

  westonruter

  committed
  5bd0575

  Copy full SHA for 5bd0575

• Fix issues and update docs

  

  delawski

  authored and

  westonruter

  committed
  97dfb1f

  Copy full SHA for 97dfb1f

• Ensure scannable URLs are AMP endpoints

  

  delawski

  authored and

  westonruter

  committed
  8815b9a

  Copy full SHA for 8815b9a

• Scan pages sequentially and visualize current scan state

  

  delawski

  authored and

  westonruter

  committed
  900503f

  Copy full SHA for 900503f

• Improve scan progress animation

  

  delawski

  authored and

  westonruter

  committed
  947ba18

  Copy full SHA for 947ba18

• Add checked page labels

  

  delawski

  authored and

  westonruter

  committed
  29c2e28

  Copy full SHA for 29c2e28

• Retrieve theme and plugin names that cause AMP validation errors

  

  delawski

  authored and

  westonruter

  committed
  577ccac

  Copy full SHA for 577ccac

• Update look and feel of scan complete Onboarding Wizard step

  

  delawski

  authored and

  westonruter

  committed
  9bc44c0

  Copy full SHA for 9bc44c0

• Add missing snapshot

  

  delawski

  authored and

  westonruter

  committed
  a88316a

  Copy full SHA for a88316a

• Add SourcesList sub-component

  

  delawski

  authored and

  westonruter

  committed
  f834380

  Copy full SHA for f834380

• Omit optional .php plugin extension in site scan results

  

  delawski

  authored and

  westonruter

  committed
  fbe3bf3

  Copy full SHA for fbe3bf3

• Add plugins context provider and use in site scan summary

  

  delawski

  authored and

  westonruter

  committed
  96438ba

  Copy full SHA for 96438ba

• Add themes context provider and use in site scan summary

  

  delawski

  authored and

  westonruter

  committed
  bfd3d5f

  Copy full SHA for bfd3d5f

• Extract themes and plugins with issues lists to sub-components

  

  delawski

  authored and

  westonruter

  committed
  7b7f296

  Copy full SHA for 7b7f296

• Improve site scan flow and allow cancelling

  

  delawski

  authored and

  westonruter

  committed
  bbaaac0

  Copy full SHA for bbaaac0

• Fix stylelint issue

  

  delawski

  authored and

  westonruter

  committed
  a648443

  Copy full SHA for a648443

• Add final message for when site scan reveals no issues

  

  delawski

  authored and

  westonruter

  committed
  49cf60e

  Copy full SHA for 49cf60e

• Add links to Validated URL page to Site Scan summary step

  

  delawski

  authored and

  westonruter

  committed
  a42e8c3

  Copy full SHA for a42e8c3

• Revert debug code

  

  delawski

  authored and

  westonruter

  committed
  3812189

  Copy full SHA for 3812189

• Allow going forward from theme selection step

  

  delawski

  authored and

  westonruter

  committed
  c0a18af

  Copy full SHA for c0a18af

• Minor code cleanup

  

  delawski

  authored and

  westonruter

  committed
  e500f70

  Copy full SHA for e500f70

• Fix phpcs issues

  

  delawski

  authored and

  westonruter

  committed
  c3f616c

  Copy full SHA for c3f616c

• Use scannable URL label provided by backend

  

  delawski

  authored and

  westonruter

  committed
  3171385

  Copy full SHA for 3171385

• Use ScannableURLs REST endpoint for getting preview URLs

  

  delawski

  authored and

  westonruter

  committed
  1ab1b73

  Copy full SHA for 1ab1b73

• Extract site scan results tables to standalone components

  

  delawski

  authored and

  westonruter

  committed
  faea80f

  Copy full SHA for faea80f

• Display Validated URL link only to technical users

  

  delawski

  authored and

  westonruter

  committed
  bdba451

  Copy full SHA for bdba451

• Migrate SiteScanResults related CSS to component folder

  

  delawski

  authored and

  westonruter

  committed
  147a5f1

  Copy full SHA for 147a5f1

• Add site scan panel on AMP settings page

  

  delawski

  authored and

  westonruter

  committed
  c0f1183

  Copy full SHA for c0f1183

• Use correct icon in Site Scan panel

  

  delawski

  authored and

  westonruter

  committed
  9fa9146

  Copy full SHA for 9fa9146

• Reverse order of template mode recommendations in Onboarding Wizard

  

  delawski

  authored and

  westonruter

  committed
  e2b6f14

  Copy full SHA for e2b6f14

• Add header copy and links to Template Modes step

  

  delawski

  authored and

  westonruter

  committed
  58d1b48

  Copy full SHA for 58d1b48

• Update CSS and copy of template mode selection Wizard step

  

  delawski

  authored and

  westonruter

  committed
  695fe03

  Copy full SHA for 695fe03

• Update function and prop names related to template mode selection

  

  delawski

  authored and

  westonruter

  committed
  6e47aa6

  Copy full SHA for 6e47aa6

• Construct AMP validation URL on the client-side

  Show description for a300ffb
  

  delawski

  authored and

  westonruter

  committed
  a300ffb

  Copy full SHA for a300ffb

• Revamp site scan context provider and UI components

  Show description for 4d5e265
  

  delawski

  authored and

  westonruter

  committed
  4d5e265

  Copy full SHA for 4d5e265

• Add validation_errors, validated_url_post, and stale to scannable-urls

  westonruter

  committed
  98bc435

  Copy full SHA for 98bc435

• Fetch cached validation errors in Site Scan on Settings page

  

  delawski

  authored and

  westonruter

  committed
  f861d55

  Copy full SHA for f861d55

• Add pre- and post-scan messages; add staleness notices

  

  delawski

  authored and

  westonruter

  committed
  ebfeaf2

  Copy full SHA for ebfeaf2

• Fix lint errors

  

  delawski

  authored and

  westonruter

  committed
  1ccee27

  Copy full SHA for 1ccee27

• Add ampFirst prop to SiteScanContextProvider and set as false on settings screen

  westonruter

  committed
  5c65e55

  Copy full SHA for 5c65e55

• Ignore some validation error codes in site scan

  

  delawski

  authored and

  westonruter

  committed
  428be92

  Copy full SHA for 428be92

• Swap conditions

  

  delawski

  authored and

  westonruter

  committed
  6ec0572

  Copy full SHA for 6ec0572

• Use default page URL only when validating in standard mode

  

  delawski

  authored and

  westonruter

  committed
  290d42f

  Copy full SHA for 290d42f

• Remove redundant constant and prop

  

  delawski

  authored and

  westonruter

  committed
  54223a3

  Copy full SHA for 54223a3

• Minor styling updates

  

  delawski

  authored and

  westonruter

  committed
  d77ce62

  Copy full SHA for d77ce62

• Cancel and invalidate scan when theme support changes

  

  delawski

  authored and

  westonruter

  committed
  5557da3

  Copy full SHA for 5557da3

• Prevent Site Scan container re-rendering on status change

  

  delawski

  authored and

  westonruter

  committed
  a8e4719

  Copy full SHA for a8e4719

• Unify naming convention; refactor delayed flag into a custom hook

  

  delawski

  authored and

  westonruter

  committed
  ee14171

  Copy full SHA for ee14171

• Remove needless condition

  

  delawski

  authored and

  westonruter

  committed
  f1ae8e6

  Copy full SHA for f1ae8e6

• Fix JS lint issue

  

  delawski

  authored and

  westonruter

  committed
  e136b4b

  Copy full SHA for e136b4b

• Patch holes in scanner UI state logic

  

  delawski

  authored and

  westonruter

  committed
  ceeb40b

  Copy full SHA for ceeb40b

• Apply suggestions from code review

  Show description for 8c1350c
  

  delawski

  and

  westonruter

  committed
  8c1350c

  Copy full SHA for 8c1350c

• Simplify site scan reducer and add failed scan state

  Show description for 25a552a
  

  delawski

  authored and

  westonruter

  committed
  25a552a

  Copy full SHA for 25a552a

• Preload themes and plugins data

  

  delawski

  authored and

  westonruter

  committed
  3994353

  Copy full SHA for 3994353

• Fix JS test

  

  delawski

  authored and

  westonruter

  committed
  4dd1fcb

  Copy full SHA for 4dd1fcb

• Determine previewPermalink in Site Scan context provider

  

  delawski

  authored and

  westonruter

  committed
  7b51924

  Copy full SHA for 7b51924

• Fix scannable-urls preload path in Onboarding Wizard

  

  delawski

  authored and

  westonruter

  committed
  16d7038

  Copy full SHA for 16d7038

• Do not determine site issues if scan is in progress

  

  delawski

  authored and

  westonruter

  committed
  73156df

  Copy full SHA for 73156df

• Focus on Site Scan panel when starting scan

  

  delawski

  authored and

  westonruter

  committed
  00d34b6

  Copy full SHA for 00d34b6

• Add missing useEffect dependency

  

  delawski

  authored and

  westonruter

  committed
  7e6ec7e

  Copy full SHA for 7e6ec7e

• Update E2E tests: increase stepper items count (Site Scan added)

  

  delawski

  authored and

  westonruter

  committed
  3c36262

  Copy full SHA for 3c36262

• Allow invalidating scannableUrl in the READY status

  

  delawski

  authored and

  westonruter

  committed
  95e74d8

  Copy full SHA for 95e74d8

• Invalidate Site Scan results whenever specific options change

  

  delawski

  authored and

  westonruter

  committed
  b53c7bd

  Copy full SHA for b53c7bd

• Use post or page URL for previewPermalink in Reader mode

  

  delawski

  authored and

  westonruter

  committed
  745039e

  Copy full SHA for 745039e

• Ensure it's possible to go through entire Onboarding Wizard in E2E tests

  

  delawski

  authored and

  westonruter

  committed
  61f958c

  Copy full SHA for 61f958c

• Fix template mode recommendations verification (E2E tests)

  

  delawski

  authored and

  westonruter

  committed
  95b7f93

  Copy full SHA for 95b7f93

• Clean up transitional-recommendation spec - overlap with template-mode spec

  

  delawski

  authored and

  westonruter

  committed
  19bed46

  Copy full SHA for 19bed46

• Add E2E tests for site scanning in Wizard and Settings page

  

  delawski

  authored and

  westonruter

  committed
  c1f5f41

  Copy full SHA for c1f5f41

• Extract AMP Setting page Review panel E2E tests to separate file

  

  delawski

  authored and

  westonruter

  committed
  640c81b

  Copy full SHA for 640c81b

• Add E2E tests for Site Scan results on AMP Settings screen

  

  delawski

  authored and

  westonruter

  committed
  ce4d1c6

  Copy full SHA for ce4d1c6

• Use Twenty Twenty as default theme in Site Scan

  

  delawski

  authored and

  westonruter

  committed
  4985064

  Copy full SHA for 4985064

• Ensure wizard button tests are async functions

  

  delawski

  authored and

  westonruter

  committed
  54ce73c

  Copy full SHA for 54ce73c

• Add E2E tests covering Site Scan summary in Onboarding Wizard

  

  delawski

  authored and

  westonruter

  committed
  b3c00ea

  Copy full SHA for b3c00ea

• Add notices for inactive and uninstalled sources

  

  delawski

  authored and

  westonruter

  committed
  220fd8c

  Copy full SHA for 220fd8c

• Show correct message if there are no site scan results yet

  

  delawski

  authored and

  westonruter

  committed
  37eeac8

  Copy full SHA for 37eeac8

• Invalidate scan results based on staleness of scannable URLs

  

  delawski

  authored and

  westonruter

  committed
  cd7fb88

  Copy full SHA for cd7fb88

• Address code review feedback

  

  delawski

  authored and

  westonruter

  committed
  70fcc43

  Copy full SHA for 70fcc43

• Merge branch 'add/validate-store-url-query-var' into feature/4719-site-scan

  Show description for ddeb234
  westonruter

  committed
  ddeb234

  Copy full SHA for ddeb234

• Add tests for add_preload_rest_paths

  westonruter

  committed
  0e134aa

  Copy full SHA for 0e134aa

• Use AMP_Validation_Manager::has_cap() in get_items_permissions_check()

  westonruter

  committed
  74b82c0

  Copy full SHA for 74b82c0

• Avoid adding paired endpoint to scannable URLs when AMP-first

  westonruter

  committed
  d1db12c

  Copy full SHA for d1db12c

• Add tests for ScannableURLsRestController and improve controller structure

  westonruter

  committed
  b0d446a

  Copy full SHA for b0d446a

Commits on Oct 26, 2021

• Merge branch 'develop' of github.com:ampproject/amp-wp into feature/4719-site-scan

  Show description for 32bf22a
  westonruter

  committed
  32bf22a

  Copy full SHA for 32bf22a

• Skip Gutenberg as a source if there are more than one

  westonruter

  committed
  7403381

  Copy full SHA for 7403381

• Apply suggestions from code review

  Show description for 3eba944
  

  delawski

  and

  westonruter

  authored
  3eba944

  Copy full SHA for 3eba944

• Fix comment alignment

  delawski

  authored
  2c66292

  Copy full SHA for 2c66292

• Use more correct 'AMP incompatibility' instead of 'issues' term

  delawski

  committed
  65fc288

  Copy full SHA for 65fc288

• Improve plugin sources normalization and slug retrieval logic

  delawski

  committed
  cfcbc92

  Copy full SHA for cfcbc92

• Keep new helper in separate file to prevent build errors

  delawski

  committed
  a797f78

  Copy full SHA for a797f78

• Use 'AMP incompatibility' instead of 'issues'

  delawski

  committed
  7ad3998

  Copy full SHA for 7ad3998

• Use clearer name for Array.reduce accumulator property

  delawski

  committed
  5ed62f8

  Copy full SHA for 5ed62f8

• Always allow re-running Site Scan

  Show description for 1313a0f
  delawski

  committed
  1313a0f

  Copy full SHA for 1313a0f

• Allow scanning only if there are scannable URLs

  delawski

  committed
  16586ff

  Copy full SHA for 16586ff

• Replace WithAMPIncompatibility with WithAmpIncompatibility

  delawski

  committed
  dcd9a44

  Copy full SHA for dcd9a44

• Get plugin slug using similar logic as in PHP

  delawski

  committed
  2b02071

  Copy full SHA for 2b02071

• Don't use external link for Validated URLs page on Settings screen

  delawski

  committed
  d5a3103

  Copy full SHA for d5a3103

• Ensure site scan is cancelled whenever AMP options are changed

  delawski

  committed
  3f80f6e

  Copy full SHA for 3f80f6e

• Remove unused imports

  delawski

  committed
  22ec597

  Copy full SHA for 22ec597

Commits on Oct 27, 2021

• Improve logic for getting plugin slug from file path

  Show description for 021df6f
  

  delawski

  and

  westonruter

  authored
  021df6f

  Copy full SHA for 021df6f

• Ensure gutenberg is excluded only if there are other error sources

  delawski

  authored
  68011a8

  Copy full SHA for 68011a8

• Update "Validated URLs" link text

  Show description for 4b4d7ea
  

  delawski

  and

  westonruter

  authored
  4b4d7ea

  Copy full SHA for 4b4d7ea

• Rename test to match tested file and remove impossible test case

  delawski

  committed
  bd39a6e

  Copy full SHA for bd39a6e

• Add test for when gutenberg isn't the only plugin for validation error

  delawski

  committed
  7d2f1d1

  Copy full SHA for 7d2f1d1

• Refactor template mode recommendation logic; use it on AMP Settings

  delawski

  committed
  cf218ea

  Copy full SHA for cf218ea

• Prevent running E2E tests on empty WordPress instance

  delawski

  committed
  27a11e2

  Copy full SHA for 27a11e2

• Update Onboarding Wizard Site Scan E2E test

  delawski

  committed
  4cb3597

  Copy full SHA for 4cb3597

• Fix E2E tests for Site Scan panel on AMP Settings screen

  delawski

  committed
  807532c

  Copy full SHA for 807532c

• Fix E2E tests for Site Review panel on AMP Settings screen

  delawski

  committed
  c83a2a9

  Copy full SHA for c83a2a9

• Disable Template Mode E2E tests on AMP Settings screen

  Show description for cc9653c
  delawski

  committed
  cc9653c

  Copy full SHA for cc9653c

• E2E: Ensure Reader Themes drawer is expanded before testing contents

  delawski

  committed
  891b1d5

  Copy full SHA for 891b1d5

Commits on Oct 28, 2021

• Convert template mode recommendation function into custom hook

  delawski

  committed
  7920d78

  Copy full SHA for 7920d78

• E2E: test if template mode recommendation is marked as stale after scan results

  delawski

  committed
  5073e8b

  Copy full SHA for 5073e8b

• Increase JS unit test coverage, remove impossible cases

  delawski

  committed
  4a9f875

  Copy full SHA for 4a9f875

• Use current user option in Wizard template mode recommendation

  delawski

  committed
  9949c8a

  Copy full SHA for 9949c8a

• Add missing comma

  delawski

  committed
  88a1fd9

  Copy full SHA for 88a1fd9

• Try fixing E2E tests

  delawski

  committed
  8836b54

  Copy full SHA for 8836b54