-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LGTM code analysis warnings #6608
Conversation
This pull request fixes 13 alerts when merging 776ceca into c8f6f6f - view on LGTM.com fixed alerts:
|
Plugin builds for 3a7f9cc are ready 🛎️!
|
This pull request fixes 13 alerts when merging dc849e8 into ed78087 - view on LGTM.com fixed alerts:
|
Co-authored-by: Weston Ruter <westonruter@google.com>
This pull request fixes 13 alerts when merging 3a7f9cc into a8706f7 - view on LGTM.com fixed alerts:
|
@@ -484,7 +483,7 @@ AmpNoloadingToggle.propTypes = { | |||
* Get AMP Lightbox toggle control. | |||
* | |||
* @param {Object} props Props. | |||
* @return {ReactElement} Element. | |||
* @return {JSX.Element} Element. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Theoretically you could have also done @return {import('react').ReactElement} Element.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm yea, I think that would require us disabling the jsdoc/valid-types
ESLint rule though. We're currently using the @wordpress/eslint-plugin/recommended-with-formatting
plugin which in turn adds JSX
as a valid type.
Summary
Fixes #6587.
Checklist