Use fixed-height layout for amp-tiktok and add height estimation #6586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Plugin builds for 1638488 are ready 🛎️!
|
pierlon
reviewed
Aug 31, 2021
Co-authored-by: Pierre Gordon <16200219+pierlon@users.noreply.github.com>
pierlon
approved these changes
Aug 31, 2021
Comment on lines
+67
to
+81
| // Initial height of video (most of them anyway). | ||
| $height = 575; | ||
|
|
||
| // Add the height of the metadata card with the CTA, username, and audio source. | ||
| $height += 118; | ||
|
|
||
| // Estimate the lines of text in the paragraph description (150-character limit). | ||
| $p = $blockquote->getElementsByTagName( Tag::P )->item( 0 ); | ||
| if ( $p instanceof Element ) { | ||
| $height += 8; // Top margin. | ||
|
|
||
| // Add height for the lines of text, where there are approx. 39 chars fit on | ||
| // a line, and a line's height is 18px. | ||
| $height += ceil( strlen( trim( $p->textContent ) ) / 39 ) * 18; | ||
| } |
There was a problem hiding this comment.
Quite a clever way of determining the height!
westonruter
added a commit
that referenced
this pull request
Aug 31, 2021
Co-authored-by: Pierre Gordon <pierregordon@protonmail.com>
|
QA Passed Given a post with the following content: <!-- wp:embed {"url":"https://www.tiktok.com/@scout2015/video/6718335390845095173","type":"video","providerNameSlug":"tiktok","responsive":true,"align":"wide"} -->
<figure class="wp-block-embed alignwide is-type-video is-provider-tiktok wp-block-embed-tiktok"><div class="wp-block-embed__wrapper">
https://www.tiktok.com/@scout2015/video/6718335390845095173
</div></figure>
<!-- /wp:embed -->
<!-- wp:embed {"url":"https://www.tiktok.com/@deeptomcruise/video/6932166297996233989?lang=en\u0026is_copy_url=0\u0026is_from_webapp=v1\u0026sender_device=pc\u0026sender_web_id=6969641973003388422","type":"video","providerNameSlug":"tiktok","responsive":true,"align":"wide"} -->
<figure class="wp-block-embed alignwide is-type-video is-provider-tiktok wp-block-embed-tiktok"><div class="wp-block-embed__wrapper">
https://www.tiktok.com/@deeptomcruise/video/6932166297996233989?lang=en&is_copy_url=0&is_from_webapp=v1&sender_device=pc&sender_web_id=6969641973003388422
</div></figure>
<!-- /wp:embed -->It can be observed that the
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When testing #6060 I found that there was quite a bit of layout shifting going on, even beyond what was reported in ampproject/amphtml#35789. The issue is with the
responsivelayout because as can be seen below, even whenamp-tiktokhas aresponsivelayout, the element does not resize responsively. Rather, the element has afixed-heightlayout:fixed-height.mov
The problem with the
responsivelayout is that the elementsamp-tiktokelements may start out extremely tall on wide pages before the elements initialize and their actual heights are supplied. This can result in a lot of layout shift, although not as bad as the non-AMP version still:before.mov
Therefore, this PR changes the layout of the
amp-tiktokelements fromresponsivetofixed-height. Additionally, it estimates the height of the metadata card by looking at the length of the description provided in the oEmbed response. The result is much improvement to CLS even to be considered good when there are 4 instances ofamp-tiktokon the page, with a vast improvement over the non-AMP oEmbed as provided by TikTok:after.mov
The
post_contentbeing shown here is as follows:Checklist