Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple tests from external TestCase dependency #6538

Merged
merged 1 commit into from
Aug 13, 2021

Conversation

pierlon
Copy link
Contributor

@pierlon pierlon commented Aug 13, 2021

Summary

Adds a local TestCase class that each test file will now extend from to decouple them from the external Yoast\WPTestUtils\WPIntegration\TestCase class.

Props to @schlessera for recommending it (#6525 (comment)).

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@pierlon pierlon added the Testing Issues related with Unit, E2E, Smoke, and other testing requirements/needs label Aug 13, 2021
@pierlon pierlon added this to the v2.2 milestone Aug 13, 2021
@pierlon pierlon requested a review from westonruter August 13, 2021 20:08
@github-actions
Copy link
Contributor

github-actions bot commented Aug 13, 2021

Plugin builds for 48bdf3f are ready 🛎️!

@pierlon pierlon force-pushed the decouple-external-testcase branch from 921ef6c to 5d99655 Compare August 13, 2021 20:25
@pierlon pierlon force-pushed the decouple-external-testcase branch from 5d99655 to 48bdf3f Compare August 13, 2021 20:27
@westonruter
Copy link
Member

I suppose you'll cherry-pick this onto a 2.1 branch PR as well?

@westonruter westonruter merged commit 041cc29 into develop Aug 13, 2021
@westonruter westonruter deleted the decouple-external-testcase branch August 13, 2021 20:34
@pierlon
Copy link
Contributor Author

pierlon commented Aug 13, 2021

I suppose you'll cherry-pick this onto a 2.1 branch PR as well?

Yep will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing Issues related with Unit, E2E, Smoke, and other testing requirements/needs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants