Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.1] Fix PHP 8 unit test GHA job #6533

Merged
merged 19 commits into from
Aug 12, 2021
Merged

[2.1] Fix PHP 8 unit test GHA job #6533

merged 19 commits into from
Aug 12, 2021

Conversation

pierlon
Copy link
Contributor

@pierlon pierlon commented Aug 12, 2021

Summary

Cherry-picks commits from #6525.

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

pierlon and others added 16 commits August 12, 2021 02:24
@pierlon
Replace deprecated assertInternalType calls with appropriate replac…
1b95e0c 
…ements
@pierlon
Replace deprecated assertContains() with `assertStringContainsStrin…
fefb352 
…g()`
@pierlon
Replace deprecated assertNotContains() with `assertStringNotContain…
6a11bbb 
…sString()`
@pierlon
Replace deprecated assertRegExp() method with `assertMatchesRegular…
52a8ee8 
…Expression()`
@pierlon
Replace deprecated assertNotRegExp() method with `assertDoesNotMatc…
9ed0f5b 
…hRegularExpression()`
@pierlon
Remove AssertContainsCompatibility trait
cfbb55e
@pierlon
Switch to yoast/wp-test-utils to handle PHPUnit installation
7d0b42f
@pierlon
Remove composer.json patch used to run phpunit on PHP 8
c86553c
@pierlon
Use polyfilled PHPUnit TestCase
dd0839c
@pierlon
Fix lint error
3b186b6
@pierlon
Fix PHPUnit warnings when running code coverage
af893b5
@pierlon
Fix named arguments
f73e53a
@pierlon
Patch phpunit/phpunit-mock-objects to run on PHP 8
4f46b2a
@pierlon
Normalize composer.json
df4ed08
@pierlon
Update composer.lock
9a77c6c
@westonruter @pierlon
Fix phpcs warnings in test-includes-admin-functions.php and update co…
cbc6774 
…mposer.lock after b9c7a40
@pierlon pierlon added this to the v2.1.4 milestone Aug 12, 2021
@pierlon pierlon requested a review from westonruter August 12, 2021 06:36
@pierlon pierlon added dependencies Pull requests that update a dependency file Infrastructure Changes impacting testing infrastructure or build tooling Testing Issues related with Unit, E2E, Smoke, and other testing requirements/needs labels Aug 12, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 12, 2021 •
edited
Loading

Plugin builds for f93ad4a are ready 🛎️!

@pierlon pierlon merged commit acd2270 into 2.1 Aug 12, 2021
@pierlon pierlon deleted the enhancement/2.1-phpunit-polyfills branch August 12, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file Infrastructure Changes impacting testing infrastructure or build tooling Testing Issues related with Unit, E2E, Smoke, and other testing requirements/needs
Projects
None yet
Milestone
v2.1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@pierlon @westonruter