Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GHA job that closes stale Gutenberg update PRs #6401

Merged
merged 2 commits into from
Jun 22, 2021
Merged

Fix GHA job that closes stale Gutenberg update PRs #6401

merged 2 commits into from
Jun 22, 2021

Conversation

pierlon
Copy link
Contributor

@pierlon pierlon commented Jun 19, 2021

Summary

  • Checks out the repo before attempting to close PR. The GitHub CLI needs to know the base repo before executing the command. Otherwise the job fails with:

    could not determine base repo: fatal: not a git repository (or any of the parent directories): .git
    /usr/bin/git: exit status 128

  • Only run the 'close PR' step when there is an open PR. Previously it was only doing this for merged PRs, which would have no effect.

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@pierlon pierlon added the Infrastructure Changes impacting testing infrastructure or build tooling label Jun 19, 2021
@pierlon pierlon added this to the v2.2 milestone Jun 19, 2021
@pierlon pierlon requested a review from westonruter June 19, 2021 03:24
@pierlon pierlon self-assigned this Jun 19, 2021
@github-actions
Copy link
Contributor

Plugin builds for e1640dd are ready 🛎️!

westonruter
westonruter approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@westonruter westonruter merged commit a958b43 into develop Jun 22, 2021
@westonruter westonruter deleted the fix/gutenberg-update-workflow branch June 22, 2021 01:35
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

Assignees
No one assigned
Labels
Changelogged Whether the issue/PR has been added to release notes. Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Milestone
v2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@pierlon @westonruter