Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rel="nofollow noreferrer noopener" to amp-wp.org link in form submission message #6082

Merged
merged 1 commit into from
Apr 21, 2021

Conversation

westonruter
Copy link
Member

Summary

Fixes #6076

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@westonruter westonruter added this to the v2.1 milestone Apr 21, 2021
@westonruter westonruter requested a review from pierlon April 21, 2021 04:16
@westonruter westonruter added Sanitizers WS:Core Work stream for Plugin core labels Apr 21, 2021
@github-actions
Copy link
Contributor

Plugin builds for 4e91000 are ready 🛎️!

@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #6082 (4e91000) into develop (8db37c3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #6082   +/-   ##
==========================================
  Coverage      74.92%   74.92%           
  Complexity      5775     5775           
==========================================
  Files            231      231           
  Lines          17483    17484    +1     
==========================================
+ Hits           13099    13100    +1     
  Misses          4384     4384           
Flag Coverage Δ Complexity Δ
javascript 79.84% <ø> (ø) 0.00 <ø> (ø)
php 74.70% <100.00%> (+<0.01%) 5775.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
includes/sanitizers/class-amp-form-sanitizer.php 98.21% <100.00%> (+0.01%) 43.00 <0.00> (ø)

@pierlon
Copy link
Contributor

pierlon commented Apr 21, 2021

Should this close #6076? This PR will only partly fix the issue (that is, adapting the shown error message).

@westonruter
Copy link
Member Author

Yes, as #4191 will address the non-SEO aspect.

@westonruter westonruter merged commit c9c3784 into develop Apr 21, 2021
@westonruter westonruter deleted the fix/form-message-seo branch April 21, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sanitizers WS:Core Work stream for Plugin core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

amp-wp.org links is not helpful for end uses and is bad for SEO
2 participants