Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily force use of Composer v1 in Travis #5543

Merged
merged 1 commit into from
Oct 27, 2020

Conversation

pierlon
Copy link
Contributor

@pierlon pierlon commented Oct 27, 2020

Summary

Travis has defaulted to Composer v2, and because of that all jobs are failing as we have dependencies that are not v2 compatible yet. This PR forces the use of v1 as a temporary measure until all of our dependencies are v2 compatible.

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@pierlon pierlon added Testing Issues related with Unit, E2E, Smoke, and other testing requirements/needs WS:Core Work stream for Plugin core labels Oct 27, 2020
@pierlon pierlon added this to the v2.0.6 milestone Oct 27, 2020
@pierlon pierlon self-assigned this Oct 27, 2020
@github-actions
Copy link
Contributor

Plugin builds for 2126146 are ready 🛎️!

@pierlon
Copy link
Contributor Author

pierlon commented Oct 27, 2020

This may or may not be needed if the build queue continues to be so long. The average wait time seems to be 3-5 hours at the moment.

@westonruter westonruter merged commit 125d06d into develop Oct 27, 2020
@westonruter westonruter deleted the force-composer-v1 branch October 27, 2020 17:54
westonruter added a commit that referenced this pull request Oct 29, 2020
…209-clipboard-friendly-errors

* 'develop' of github.com:ampproject/amp-wp: (174 commits)
  Temporarily force of Composer v1 in CI (#5543)
  Fix typo in Optimizer readme (#5535)
  Include file.php separately from class-wp-upgrader.php (#5539)
  Add PhpIncludeInspection annotation
  Add PhpUnusedParameterInspection annotation
  Capture the original block render_callbacks to detect originating plugin
  Fix Gutenberg 9.2.1 compat due to gutenberg_current_parsed_block_tracking()
  Ensure full coverage for test_get_plugin_dir
  Skip Facebook tests earlier when external-http; update skip message
  Fix CSSList splicing and eliminate reliance on buggy replace/splice methods
  Add more removed rules that cause splice issue
  Add charset rule to allowed_at_rules_retained test data
  Ensure -moz-document rule is removed after replaced
  Skip FB test once testing external-http suite
  Add test for PluginRegistry::get_plugin_dir()
  Ensure css_list is sanitized after -moz-document transformation
  Transform -moz-document at-rule Firefox hack into supports hack
  Fix lint error
  Manually bootstrap WP CLI
  Skip test if Facebook oEmbed endpoint is down
  ...
@johnwatkins0
Copy link
Contributor

Moving this to QA passed, as it is now obsolete following the switch from Travis to GitHub actions.

@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelogged Whether the issue/PR has been added to release notes. Testing Issues related with Unit, E2E, Smoke, and other testing requirements/needs WS:Core Work stream for Plugin core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants