-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add buttons to copy error details to clipboard #5500
Merged
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
0b8c793
Add buttons to copy error details to clipboard
johnwatkins0 b2b5c14
Move clipboard functions into own module and prettyprint JSON
johnwatkins0 3cfad55
Resolve failing test
johnwatkins0 f73e574
Add tests for clipboard-friendly error button
johnwatkins0 fe35801
Convert error node_type to constant name in JSON
johnwatkins0 c4e1a64
Update markup status in JSON data in case it has changed
johnwatkins0 61e571a
Use clipboard.js package for copying to clipboard
johnwatkins0 08d9237
Disable eslint rule per line
johnwatkins0 0153b68
Remove unneeded helper function
johnwatkins0 ddf5ec4
Copy to clipboard: restore focus state and show 'copied' text
johnwatkins0 47fc7be
Copy to clipboard: handle case where clicks button again immediately
johnwatkins0 7e1d5a9
Make 'copy to clipboard' text consistent
johnwatkins0 4bae05c
Clipboard-friendly errors: use status from DB instead of from UI
johnwatkins0 d2382e8
Clipboard-friendly errors: convert status to removed bool and add rev…
johnwatkins0 c83dbb8
No need to pretty-print error details on the backend
johnwatkins0 e7dbb5d
Merge remote-tracking branch 'origin/develop' into feature/5209-clipb…
johnwatkins0 54ecc46
Parse and re-stringify JSON data to prettify
johnwatkins0 23fbfed
Remove unnecessary aria-label
johnwatkins0 82edbbd
Merge branch 'develop' of github.com:ampproject/amp-wp into feature/5…
westonruter e4abee8
Merge branch 'feature/5209-clipboard-friendly-errors' of github.com:a…
westonruter f6bb8ad
Fix test_get_error_details_json
westonruter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor bug:
Clicking on the button while it's showing the updated text permanently sets it to said text:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, looking at my code, that bug makes perfect sense 🤦 Fixing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the catch, @pierlon. Fixed in 47fc7be