Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve description of the native and transitional template modes #2089

Merged
merged 2 commits into from
Apr 8, 2019

Conversation

amedina
Copy link
Member

@amedina amedina commented Apr 8, 2019

This change emphasizes the transient nature of the Transitional mode as a path towards a fully AMP-first site.

@amedina amedina requested a review from westonruter April 8, 2019 20:57
@googlebot googlebot added the cla: yes Signed the Google CLA label Apr 8, 2019
@westonruter westonruter added this to the v1.1 milestone Apr 8, 2019
@westonruter westonruter merged commit 1c68e22 into develop Apr 8, 2019
@westonruter westonruter deleted the amedina/mode-rebranding branch April 8, 2019 21:35
@westonruter
Copy link
Member

@amedina should the “development work” sentence have links back to the documentation on ampwp.org? Once the user dismisses the welcome banner, I realize there is no persistent links back to the site:

Screen Shot 2019-04-11 at 21 56 00

@amedina
Copy link
Member Author

amedina commented Apr 12, 2019

Good point. We should include the link back to the site. Will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Signed the Google CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants