Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore cursor:pointer for menu-scroll-down in Twenty Seventeen #1830

Merged
merged 1 commit into from
Jan 18, 2019
Merged

Restore cursor:pointer for menu-scroll-down in Twenty Seventeen #1830

merged 1 commit into from
Jan 18, 2019

Conversation

westonruter
Copy link
Member

Amends #1777.

Because add_smooth_scrolling removes the href attribute on the .menu-scroll-down element:

image

The pointer:cursor style needs to be re-added manually.

@westonruter westonruter added this to the v1.0.2 milestone Jan 18, 2019
@googlebot googlebot added the cla: yes Signed the Google CLA label Jan 18, 2019
@westonruter westonruter merged commit 44196c2 into 1.0 Jan 18, 2019
@westonruter westonruter deleted the fix/menu-croll-down-pointer-cursor branch January 18, 2019 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy approved these changes

Assignees
No one assigned
Labels
cla: yes Signed the Google CLA
Projects
None yet
Milestone
v1.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@westonruter @swissspidy @googlebot