Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict assets to only be enqueued on amp_validated_url edit post screen #1798

Merged
merged 1 commit into from
Jan 9, 2019

Conversation

westonruter
Copy link
Member

The amp-validation-single-error-url style and amp-validation-single-error-url-details script are currently getting enqueued on every edit post screen, regardless of the post type. This is incorrect, as they should only be enqueued for the amp_validated_url post type.

Fixes #1796.

@westonruter westonruter added this to the v 1.0.2 milestone Jan 7, 2019
@googlebot googlebot added the cla: yes Signed the Google CLA label Jan 7, 2019
@westonruter westonruter requested a review from felixarntz January 7, 2019 19:37
@westonruter westonruter merged commit d04af55 into 1.0 Jan 9, 2019
@westonruter westonruter deleted the fix/enqueueing-single-error-url-assets branch January 9, 2019 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Signed the Google CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants