Gracefully handle conflicting version of PHP-CSS-Parser being loaded #1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's a build of the plugin on this branch: amp.zip |
|
Approved Hi @westonruter, The admin notice appeared when the Mailpoet plugin was active, but it didn't appear otherwise. |
kienstra
approved these changes
Dec 14, 2018
| @@ -1946,6 +2006,10 @@ private function finalize_styles() { | |||
| } | |||
| } | |||
|
|
|||
| if ( ! self::has_required_php_css_parser() ) { | |||
| $comment .= "\n" . esc_html__( '!!!WARNING!!! AMP CSS processing is limited because a conflicting version of PHP-CSS-Parser has been loaded by another plugin/theme. Tree shaking is not available.', 'amp' ) . "\n"; | |||
| } | |||
There was a problem hiding this comment.
This looks good when the Mailpoet plugin is active.
| '<div class="notice notice-warning"><p>%s</p></div>', | ||
| sprintf( | ||
| /* translators: %s is location where conflicting lib was found */ | ||
| esc_html__( "A conflicting version of PHP-CSS-Parser appears to be installed by another plugin/theme (located in '%s'). Because of this CSS processing will be limited, and tree shaking will not be available.", 'amp' ), |
There was a problem hiding this comment.
This notice looks good when Mailpoet is active:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Via https://wordpress.org/support/topic/500-error-on-post-pages-without-yoast-glue-plugin/
When another plugin/theme is installed which also has a copy of PHP-CSS-Parser, if its Composer autoloader wins then the required methods and functionality of our fork will not be available. In this case, all of the CSS processing will not be available, including tree shaking.
So this PR detects for a conflicting version being installed, and it will show a warning:
Additionally, feature detection is now done with fallbacks to the methods that are available.
When the required PHP-CSS-Parser is not available, then the
style[amp-custom]manifest comment will indicate this with a warning:Classic mode in particular should work acceptably when the required version of PHP-CSS-Parser is not available.