Update the readme and amp.php for the 1.0.1 release #1734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the PRs from the 1.0.1 milestone: https://github.com/ampproject/amp-wp/milestone/11?closed=1 Also, add the date of the release, instead of 'unreleased'.
To ensure the same versions appear in amp.php and the readme files.
Of course, this is a final step, so this should wait for smoke testing.
kienstra
changed the title
westonruter
reviewed
Dec 12, 2018
westonruter
reviewed
Dec 12, 2018
As Weston mentioned, I needed to do: git submodule update --init --recursive
kienstra
commented
Dec 13, 2018
| @@ -19,6 +19,10 @@ again. | |||
|
|
|||
| The list of contributors who are featured on the WordPress.org plugin directory are subject to change over time. The organizations and individuals who contribute significantly and consistently (e.g. 3-month period) to the project are eligible to be listed. Those listed should generally be considered as those who take responsibility for the project (i.e. owners). Note that contributions include more than just code, though contributors who commit are [most visible](https://github.com/ampproject/amp-wp/graphs/contributors). The sort order of the contributors list should generally follow the sort order of the GitHub contributors page, though again, this order does not consider work in issues and the support forum, so it cannot be relied on solely. | |||
|
|
|||
| ## Branches | |||
|
|
|||
| To include your changes in the next patch release (e.g. `1.0.x`), please base your branch off of the current release branch (e.g. `1.0`) and open your pull request back to that branch. If you open your pull request with the `develop` branch then it will be by default included in the next minor version (e.g. `1.x`). | |||
There was a problem hiding this comment.
Good idea, this should prevent having to rebase branches.
westonruter
changed the title
westonruter
approved these changes
Dec 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.0.1