Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for required iconv extension #1727

Merged
merged 1 commit into from
Dec 12, 2018
Merged

Add check for required iconv extension #1727

merged 1 commit into from
Dec 12, 2018

Conversation

westonruter
Copy link
Member

@westonruter westonruter added this to the v1.0.1 milestone Dec 11, 2018
@westonruter westonruter requested a review from kienstra December 11, 2018 23:20
@kienstra
Copy link
Contributor

Approved

Hi @westonruter,
Sorry for the delay. This notice looks good when I change the conditional (my environment has the iconv extension):

amp-iconv-extension-notice

@westonruter westonruter merged commit 1bf0d5e into 1.0 Dec 12, 2018
@westonruter westonruter deleted the fix/iconv-detection branch December 12, 2018 21:30
@westonruter westonruter mentioned this pull request Dec 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kienstra kienstra kienstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@westonruter @kienstra