Code

Add single error url page#1418

Code

Merged

westonruter merged 93 commits intodevelopampproject/amp-wp:developfrom add/1365-single-error-urlampproject/amp-wp:add/1365-single-error-urlCopy head branch name to clipboardSep 21, 2018

+1,845-519

Commits

Commits on Sep 6, 2018

• Begin prototype for single error URL post.php page

  Show description for e616a08
  kienstra

  committed
  e616a08

  Copy full SHA for e616a08

• Output a search box, though it will need to move above the 'Status' box

  kienstra

  committed
  f809c3d

  Copy full SHA for f809c3d

Commits on Sep 7, 2018

• Refactor simple anonymous function into method with PHPUnit test

  Show description for 469d3d2
  kienstra

  committed
  469d3d2

  Copy full SHA for 469d3d2

• Create method get_terms_per_page()

  Show description for 93b4f26
  kienstra

  committed
  93b4f26

  Copy full SHA for 93b4f26

• Add a unit test for parse_post_php_term_query()

  Show description for d91786d
  kienstra

  committed
  d91786d

  Copy full SHA for d91786d

• Remove print_validation_errors_meta_box(), though might borrow some logic

  Show description for 96141eb
  kienstra

  committed
  96141eb

  Copy full SHA for 96141eb

• Move template list table into method

  Show description for 7d501f0
  kienstra

  committed
  7d501f0

  Copy full SHA for 7d501f0

Commits on Sep 8, 2018

• Add unit test for render_single_url_list_table

  Show description for 500a6f5
  kienstra

  committed
  500a6f5

  Copy full SHA for 500a6f5

Commits on Sep 10, 2018

• Merge branch 'develop' into add/1365-single-error-url

  kienstra

  committed
  9446f68

  Copy full SHA for 9446f68

• Reorder methods, add example URLs to DocBlock

  Show description for 37e29f6
  kienstra

  committed
  37e29f6

  Copy full SHA for 37e29f6

• Output the error type in that column

  Show description for 9adc5d4
  kienstra

  committed
  9adc5d4

  Copy full SHA for 9adc5d4

• Allow filtering the single error page by type

  Show description for 67955cb
  kienstra

  committed
  67955cb

  Copy full SHA for 67955cb

• Add the <tr> with 'Showing 4 of x validation errors' at the top of the list table

  Show description for b8d8459
  kienstra

  committed
  b8d8459

  Copy full SHA for b8d8459

Commits on Sep 11, 2018

• Use dynamic values and translated text for the 'Showing errors' text

  Show description for e8e7906
  kienstra

  committed
  e8e7906

  Copy full SHA for e8e7906

• If there are no errors to show, do not display this message

  Show description for 2473214
  kienstra

  committed
  2473214

  Copy full SHA for 2473214

• Allow searching for errors

  Show description for 838c393
  kienstra

  committed
  838c393

  Copy full SHA for 838c393

• Minor DocBlock improvements

  Show description for 6324b34
  kienstra

  committed
  6324b34

  Copy full SHA for 6324b34

• Instead of adding the taxonomy as a query var, add it to $_REQUEST

  Show description for aef6e05
  kienstra

  committed
  aef6e05

  Copy full SHA for aef6e05

• Correct failed unit test, updating with latest change

  Show description for 9aaffdf
  kienstra

  committed
  9aaffdf

  Copy full SHA for 9aaffdf

• Remove PHP logic for displaying search term(s), change number of posts to PHP_INT_MAX

  Show description for 834b141
  kienstra

  committed
  834b141

  Copy full SHA for 834b141

• Remove PHP logic to support filtering and searching

  Show description for c4ed164
  kienstra

  committed
  c4ed164

  Copy full SHA for c4ed164

• Filter the errors by type, using JavaScript

  Show description for 4a1e7f0
  kienstra

  committed
  4a1e7f0

  Copy full SHA for 4a1e7f0

• Address Travis error by removing empty line

  kienstra

  committed
  a552168

  Copy full SHA for a552168

Commits on Sep 12, 2018

• Match text formatting of the desings for the 'Error' and 'Details' columns

  Show description for 3fe3ffa
  kienstra

  committed
  3fe3ffa

  Copy full SHA for 3fe3ffa

• Apply the design for the link at the top of the page

  Show description for d9c7113
  kienstra

  committed
  d9c7113

  Copy full SHA for d9c7113

Commits on Sep 13, 2018

• Move 'Last checked' UI above 'Recheck' button

  Show description for 67530a4
  kienstra

  committed
  67530a4

  Copy full SHA for 67530a4

• Move 'Last checked' UI lower, to match designs

  Show description for af06e79
  kienstra

  committed
  af06e79

  Copy full SHA for af06e79

• Add <select> element in the status column, reusing previous <select> from this page

  Show description for b5c1fb9
  kienstra

  committed
  b5c1fb9

  Copy full SHA for b5c1fb9

• Merge branch 'develop' into add/1365-single-error-url

  kienstra

  committed
  0b02674

  Copy full SHA for 0b02674

• Merge in develop, resolve conflicts

  Show description for 66e3a6f
  kienstra

  committed
  66e3a6f

  Copy full SHA for 66e3a6f

• Change 'Identified' to 'New', update another unit test

  Show description for 384be89
  kienstra

  committed
  384be89

  Copy full SHA for 384be89

• Remove the 'Apply Filter' button, and update the errors on simply changing the <select>

  Show description for fb57681
  kienstra

  committed
  fb57681

  Copy full SHA for fb57681

Commits on Sep 14, 2018

• Add and support 'Accept' and 'Reject' buttons for bulk actions

  Show description for 4a1e21c
  kienstra

  committed
  4a1e21c

  Copy full SHA for 4a1e21c

• Address the Travis error, by changing the class to Exception

  Show description for 9d301f2
  kienstra

  committed
  9d301f2

  Copy full SHA for 9d301f2

• Update styling for the 'Accept' and 'Reject' buttons

  Show description for ebddc40
  kienstra

  committed
  ebddc40

  Copy full SHA for ebddc40

• Use the 'Accepted' icon in the post meta box

  Show description for a364758
  kienstra

  committed
  a364758

  Copy full SHA for a364758

• Merge branch 'develop' into add/1365-single-error-url

  kienstra

  committed
  1a282b7

  Copy full SHA for 1a282b7

• Apply John's work with sortable columns

  Show description for bca2650
  kienstra

  committed
  bca2650

  Copy full SHA for bca2650

• Add the callback that enables ordering to the single URL page

  Show description for 589b92f
  kienstra

  committed
  589b92f

  Copy full SHA for 589b92f

Commits on Sep 16, 2018

• Change the page header to match the design

  Show description for 7936fab
  kienstra

  committed
  7936fab

  Copy full SHA for 7936fab

Commits on Sep 18, 2018

• Merge branch 'develop' into add/1365-single-error-url

  Show description for 2fa80f6
  jacobschweitzer

  committed
  2fa80f6

  Copy full SHA for 2fa80f6

Commits on Sep 19, 2018

• Single error URL page - add expanded details view

  johnwatkins0

  committed
  fbabf80

  Copy full SHA for fbabf80

• Merge branch 'add/1365-single-error-url' of https://github.com/Automattic/amp-wp into add/1365-single-error-url

  johnwatkins0

  committed
  3ca22ee

  Copy full SHA for 3ca22ee

• Fixes after merge and small style imnprovements

  johnwatkins0

  committed
  6d9d60a

  Copy full SHA for 6d9d60a

• Reuse the existing logic to render the 'Sources' column

  Show description for d4307a7
  kienstra

  committed
  d4307a7

  Copy full SHA for d4307a7

• Apply existing styling to the 'Sources' column

  Show description for 5d52bf0
  kienstra

  committed
  5d52bf0

  Copy full SHA for 5d52bf0

• Apply the existing icons to the 'Status' column

  Show description for b4d4d60
  kienstra

  committed
  b4d4d60

  Copy full SHA for b4d4d60

• Address failed Travis builds

  Show description for 02bc366
  kienstra

  committed
  02bc366

  Copy full SHA for 02bc366

• Display the 'AMP Enabled' status in the post meta box

  Show description for 8edf16e
  kienstra

  committed
  8edf16e

  Copy full SHA for 8edf16e

• Improve styling of 'AMP enabled' icon

  Show description for 957bb3f
  kienstra

  committed
  957bb3f

  Copy full SHA for 957bb3f

• Change the status icon as the user chooses a status from the <select>

  Show description for 9878448
  kienstra

  committed
  9878448

  Copy full SHA for 9878448

• Fix an issue in switching back to 'New' status

  Show description for 3d63291
  kienstra

  committed
  3d63291

  Copy full SHA for 3d63291

• Restore logic to 'Preview Changes'

  Show description for 8b2c568
  kienstra

  committed
  8b2c568

  Copy full SHA for 8b2c568

• Merge branch 'develop' into add/1365-single-error-url

  kienstra

  committed
  f80b5e2

  Copy full SHA for f80b5e2

• Remove a reference to the constant VALIDATION_DETAILS_NODE_NAME_QUERY_VAR

  Show description for 1b4c43c
  kienstra

  committed
  1b4c43c

  Copy full SHA for 1b4c43c

• Implement inline actions, like 'Accept' and 'Reject'.

  Show description for 19fc70d
  kienstra

  committed
  19fc70d

  Copy full SHA for 19fc70d

• Edit some DocBlocks, remove dom-ready from webpack.config.js

  Show description for e09db3d
  kienstra

  committed
  e09db3d

  Copy full SHA for e09db3d

• Implement a basic JS search for errrors, using the 'Details' column

  Show description for 738f2ad
  kienstra

  committed
  738f2ad

  Copy full SHA for 738f2ad

• Fix an issue in passing the wrong argument to handle_validation_error_update()

  Show description for bdf411e
  kienstra

  committed
  bdf411e

  Copy full SHA for bdf411e

• Use intval() in sanitization, check that ! empty()

  Show description for c8807bd
  kienstra

  committed
  c8807bd

  Copy full SHA for c8807bd

• Fix more escaping, like using intval()

  Show description for 2d3f30e
  kienstra

  committed
  2d3f30e

  Copy full SHA for 2d3f30e

• Instead of a boolean flag, use an array of arguments

  Show description for 9cafbeb
  kienstra

  committed
  9cafbeb

  Copy full SHA for 9cafbeb

• Remove default argument value, add a check for ! event.target.value

  Show description for 4829932
  kienstra

  committed
  4829932

  Copy full SHA for 4829932

• Move styling from JSS to CSS

  Show description for 00c11dd
  kienstra

  committed
  00c11dd

  Copy full SHA for 00c11dd

• If all of the rows are showing, hide the notice

  Show description for 2c1c140
  kienstra

  committed
  2c1c140

  Copy full SHA for 2c1c140

Commits on Sep 20, 2018

• Merge in develop, resolve merge conflict

  Show description for 4875775
  kienstra

  committed
  4875775

  Copy full SHA for 4875775

• Add a 'Show all' button to display all errors

  Show description for 029b986
  kienstra

  committed
  029b986

  Copy full SHA for 029b986

• Output the sources is the expandable 'Error' section

  Show description for 0da5582
  kienstra

  committed
  0da5582

  Copy full SHA for 0da5582

• Address Travis error by moving parameter name 2 spaces to the right

  Show description for e7b194f
  kienstra

  committed
  e7b194f

  Copy full SHA for e7b194f

• On clicking 'Show all,' change the error type <select> to 'All Error Types'

  Show description for 03cd2a8
  kienstra

  committed
  03cd2a8

  Copy full SHA for 03cd2a8

• Change 'Reject' icon to red

  Show description for 756b884
  kienstra

  committed
  756b884

  Copy full SHA for 756b884

• Only display the 'Accept' and 'Reject' bulk action buttons if a checkbox is checked

  Show description for 9074772
  kienstra

  committed
  9074772

  Copy full SHA for 9074772

• Fix styling issue in 'Accept' and 'Reject' buttons, remove dead code

  Show description for 5965fee
  kienstra

  committed
  5965fee

  Copy full SHA for 5965fee

• Rename CSS file to reflect that it applies to the whole page

  Show description for 731f313
  kienstra

  committed
  731f313

  Copy full SHA for 731f313

• Fix undefined index notices related to queried_object meta missing

  westonruter

  committed
  f2b62e8

  Copy full SHA for f2b62e8

• On clicking 'Show all', still show the notice with the count

  Show description for 8e427d7
  kienstra

  committed
  8e427d7

  Copy full SHA for 8e427d7

• Prevent showing the 'Invalid URL' page header before it's overwritten in JS

  Show description for 9db69ee
  kienstra

  committed
  9db69ee

  Copy full SHA for 9db69ee

• Update Accept/Reject buttons to update select dropdown, not submit form.

  Show description for b6695c3
  westonruter

  committed
  b6695c3

  Copy full SHA for b6695c3

• When all of the errors are displaying, hide the notice

  Show description for 75f128f
  kienstra

  committed
  75f128f

  Copy full SHA for 75f128f

• Because the show all button might be newly created, do a new query for it

  Show description for 505a42e
  kienstra

  committed
  505a42e

  Copy full SHA for 505a42e

• Fix presentation of toggle button in narrower screen resolutions

  Show description for 2ba31f9
  westonruter

  committed
  2ba31f9

  Copy full SHA for 2ba31f9

Commits on Sep 21, 2018

• Commit changes in order to merge remote

  johnwatkins0

  committed
  818259e

  Copy full SHA for 818259e

• Merge branch 'develop' of https://github.com/Automattic/amp-wp into add/1365-single-error-url

  westonruter

  committed
  5f15604

  Copy full SHA for 5f15604

• Single error view - add toggle all button for sources column

  johnwatkins0

  committed
  aa21e14

  Copy full SHA for aa21e14

• Merge remote and resolve conflicts

  johnwatkins0

  committed
  b28875c

  Copy full SHA for b28875c

• Merge develop into add/1365-single-error-url

  johnwatkins0

  committed
  5b7c2e0

  Copy full SHA for 5b7c2e0

• Single error view - remove debug statement

  johnwatkins0

  committed
  39cb830

  Copy full SHA for 39cb830

• Validation - tooltip fixes

  johnwatkins0

  committed
  f0668f7

  Copy full SHA for f0668f7

• Validation - PHPCS fixes

  johnwatkins0

  committed
  da5169b

  Copy full SHA for da5169b

• Validation - PHPCS fixes

  johnwatkins0

  committed
  3dce980

  Copy full SHA for 3dce980

• Validation PHPUnit - restore removed line in test

  johnwatkins0

  committed
  8d603f4

  Copy full SHA for 8d603f4

• Don't show the 'Reject' and 'Accept' action links on the single URL page.

  Show description for d5b3a42
  kienstra

  committed
  d5b3a42

  Copy full SHA for d5b3a42

• Set document title in addition to the heading

  westonruter

  committed
  f0677bf

  Copy full SHA for f0677bf