Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum PHP version from 5.3.2 to 5.3.6 #1407

Merged
merged 2 commits into from
Sep 7, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion amp.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ function _amp_print_php_version_admin_notice() {
</div>
<?php
}
if ( version_compare( phpversion(), '5.3.2', '<' ) ) {
if ( version_compare( phpversion(), '5.3.6', '<' ) ) {
add_action( 'admin_notices', '_amp_print_php_version_admin_notice' );
return;
}
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
}
],
"require": {
"php": "^5.3.2 || ^7.0",
"php": "^5.3.6 || ^7.0",
"sabberworm/php-css-parser": "dev-master"
},
"require-dev": {
Expand Down
12 changes: 6 additions & 6 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion phpunit.xml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<directory prefix="test-" suffix=".php">./tests/</directory>
</testsuite>
<testsuite name="Test Tag and Attribute Sanitizer Private Methods">
<file phpVersion="5.3.2" phpVersionOperator=">=">./tests/amp-tag-and-attribute-sanitizer-private-methods-tests.php</file>
<file phpVersion="5.3.6" phpVersionOperator=">=">./tests/amp-tag-and-attribute-sanitizer-private-methods-tests.php</file>
</testsuite>
</testsuites>
<filter>
Expand Down
2 changes: 1 addition & 1 deletion readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Enable Accelerated Mobile Pages (AMP) on your WordPress site.
**Tested up to:** 4.9
**Stable tag:** 0.7.2
**License:** [GPLv2 or later](http://www.gnu.org/licenses/gpl-2.0.html)
**Requires PHP:** 5.3.2
**Requires PHP:** 5.3.6

[![Build Status](https://travis-ci.org/Automattic/amp-wp.svg?branch=master)](https://travis-ci.org/Automattic/amp-wp) [![Built with Grunt](https://cdn.gruntjs.com/builtwith.svg)](http://gruntjs.com)

Expand Down
2 changes: 1 addition & 1 deletion readme.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Tested up to: 4.9
Stable tag: 0.7.2
License: GPLv2 or later
License URI: http://www.gnu.org/licenses/gpl-2.0.html
Requires PHP: 5.3.2
Requires PHP: 5.3.6

Enable Accelerated Mobile Pages (AMP) on your WordPress site.

Expand Down