Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add dynamic handling of validation errors #1063

Closed
wants to merge 3 commits into from

Commits on Apr 6, 2018

  1. Configuration menu
    Copy the full SHA
    7bd658d View commit details
    Browse the repository at this point in the history
  2. Allow the validation_error_callback to return false to prevent saniti…

    …zation where relevant
    
    * Move debug code into AMP_Validation_Utils class.
    * Remove disable_invalid_removal sanitizer arg in favor of validation_error_callback
    westonruter committed Apr 6, 2018
    Configuration menu
    Copy the full SHA
    73f4373 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2018

  1. Improve handling of validation errors in style sanitizer

    * Run amp_content_sanitizers filter late to apply after sanitizers have been added.
    * Wrap any existing validation_error_callback functions which have been supplied to do the handling of the validation error.
    * Pass flag to style sanitizer to locate_sources to ensure sources are available for reporting when they'll be needed.
    * Add handle_validation_error and set_current_node methods to reduce duplication.
    * Fix inclusion of property_value in validation_error.
    * Pass debug flag to AMP_Validation_Utils upon init.
    westonruter committed Apr 7, 2018
    Configuration menu
    Copy the full SHA
    f11e6c4 View commit details
    Browse the repository at this point in the history