Issue #868: Add Comment Unit Tests for PR #909 #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 30, 2018 11:09
Add a test for process_comment_form(). @todo: continue with that, and AMP_Comments_Sanitizer::sanitize().
Test more of the method, including the 'on' value of the form elements.
Improve some of the method descriptions. And move parent::setUp() to the bottom of setUp().
I deleted some empty lines, and that moved some lines together. Those lines need their = to be vertically-aligned.
Remove \ before WP_UnitTestCase. This test isn't in a namespace, so it isn't needed.
kienstra
changed the title
westonruter
approved these changes
Apr 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request For Review
Hi @westonruter,
No hurry here, as this is a holiday. But when you can, could you please review this PR for Issue #868?
It adds PHPUnit tests for #909. PR #1034 has the tests for
AMP_Theme_Support.