Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AMP status notification to the pre-publish panel and to the AMP panel in the document sidebar #5997

Closed
delawski opened this issue Mar 19, 2021 · 1 comment · Fixed by #6027
Assignees
Labels
Editor Enhancement New feature or improvement of an existing one WS:UX Work stream for UX/Front-end
Milestone

Comments

@delawski
Copy link
Collaborator

Feature description

As proposed in #5304, the AMP validation status notifications have been revamped in the AMP sidebar in #5929.

A similar notification should be now added to the editor pre-publish panel and to the AMP panel in the document sidebar.

Screenshot 2021-03-19 at 16 29 51

Screenshot 2021-03-19 at 16 30 02


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

@delawski delawski added Enhancement New feature or improvement of an existing one Editor WS:UX Work stream for UX/Front-end labels Mar 19, 2021
@westonruter westonruter added this to the v2.1 milestone Mar 19, 2021
@delawski delawski self-assigned this Mar 24, 2021
delawski added a commit that referenced this issue Mar 25, 2021
The two entry points: `block-validation` and `block-editor` are both used in the context of the block editor. Potentially they could share the same entry point so that code re-usability would be better.

This is the first step of the process. The directory structure of the `block-validation` is now more organized and should match the structure of the `block-editor` folder.

This change will also allow us to cleanly migrate the `amp-toggle` plugin from `block-editor` to `block-validation`. With #5997, this plugin logically belongs to `block-validation` since it renders AMP status notification that in turn is based on the AMP validation status.
@jwold jwold self-assigned this Apr 23, 2021
@jwold
Copy link
Collaborator

jwold commented Apr 23, 2021

Tested all the states mentioned above. Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Editor Enhancement New feature or improvement of an existing one WS:UX Work stream for UX/Front-end
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants