-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move adding background media to the toolbar, or a readily visible place. #2699
Comments
Could the background image use the featured image? We could filter and change the name of the featured image to background image. Not sure if this would cause other issues with meta data for example. This issue reminds me a little of this - WordPress/gutenberg#13795 |
Put some thought into this one. Here is my recommendation.
Pros Cons |
Q: What's the benefit of adding a new Background block instead of using the Page block for the background and just using the Media icon for the 4 options with the existing Page block? Wondering why would it be beneficial if background would be a separate block ("Everything is then a block."). Displaying the background in the Sidebar does feel like a benefit but we could alternatively also add an item there that would just select the Page (name it sth else that suits better), without actually adding a separate block for it.
Q: How would changing the background media happen?
Q: Where would the opacity, background color and -gradient live?
Q: Wouldn't this make it more painful configuring the background? E.g. when modifying the opacity it's quite useful to see the top blocks as well for understanding which value is the best. Thoughts? |
How would this work? What would happen on the media icon is selected? A dialog pops up? It force the sidebar to visable and background options expanded?
Isn't the point of this ticket, is users can't find the options in the sidebar? The benefit of that background is that is moves the background options into the page, making it more WYSIWYG and that the two things are connected.
All options to get the background, such as colour and media would be in that block.
I would see how this might be confusing. Maybe a seperate background button should be added to the toolbar. The key benefit of having the background as a block, as it would be listed elements and would be managed within the page area. However, they maybe too many options to do this in a way that scales to many screens. I personally believe that the sidebar is the best place for these options. It keeps the background options inline with other similar blocks like the cover block. Maybe the best options is just force the side to display when a page is selected, have background media expanded. Maybe even rename background media to background image / video to make it a little clearer. |
I'm also wary of adding a separate block for the background, at least for the moment. As for the sidebar, there'd still need to be features like the focal point picker in it anyway. I'd keep it simple for now:
+1
Perhaps even four options:
It could still be shown, but it would just replace the existing image/video. As for the better discovery, we could do this:
This placeholder would only be shown when these conditions are met:
Examples of placeholders: See design guidelines for examples of placeholders and best practices: https://developer.wordpress.org/block-editor/designers/block-design/ |
An example of popover when clicking on the icon (with the 4 Media options: background image, background video, video, image): It could be something similar. Additionally, we could add the "Background" link to the Block Navigation for testing it out, there is even an issue for it: |
(Note: added AC5 to the description, that was missing, added based on yesterday's discussion.) |
+1 This is basically what I discussed yesterday. I think added toolbar is a little confusing. I personally wouldn't think to look there for a background option. Specially after using other places like the cover block. I think the issue is that in testing people were clicking on the image icon in the toolbar as they didn't know where click. I think most people think about background as the first when creating a story. Like a painting, you paint the background and then paint foreground characters on top. This is a layering effect. So how about this flow.
|
That's what came out in the user testing as well.
The idea is that the user shouldn't need to know where to click, it should be intuitive. The best verification we have so far is user testing, if that's the place where the users are clicking then why not provide the actual functionality as well. A lot of the WP editor was built without real user testing (other than the engineers who aren't the main target users really) so the actual users might know better :)
Background Media would be a good case for adding a placeholder, background color and opacity on the other hand don't feel like it. How would you implement that as a placeholder within the Page? If the Background Colors Panel is open by default then this is quite visible, perhaps that would be enough? |
@swissspidy - I am not sure we need the placeholder since this is a new user issue mostly. I fear it might clutter up the UX a tiny bit. So considered the NUX guidance instead. Because once you know, you can turn that off. |
I would argue that users think of background as one thing. Splitting half the options for background into two is a little confusing IMO. If you just have a background image, you may not know / understand you can add an overlay as that option is in an unconnected sidebar.
It is going to be a common behaviour for most users to change the background image for these rich stories. It is cluttering them up or is it putting commonly used options, front and centre. |
Just for clarification: All the Background Settings are Block Settings of the Page Block. So when a Page block is selected and Image added then the colors are visible on the right sidebar right away. It's quite connected sidebar :D On having just the image as a placeholder: it's about what is suitable as a placeholder inside a Page. For example, if you think of about the Image block -- it's a placeholder when added but all the settings are in the block sidebar, it would be quite odd adding a setting from the block sidebar to the Image block placeholder as well. Maybe we can start with what we agreed on yesterday, then we test it out and change/modify it if it feels that it's not the best option? Thoughts? What we discussed yesterday in grooming:
Then we could test it out and review with @cathibosco (UX) and adjust as necessary. If it feels like it's still confusing then we can add additional stuff and test out a placeholder. WDYT? |
+1. This is a no-brainer.
Let's keep it simple for now, with 4 options all the time.
Not sure if that would really grab the user's attention. On a large screen, I would probably hardly notice that the sidebar has changed and nothing else. |
Don't have a large screen, wouldn't know :D However, I don't have a strong preference about this anyway. |
+1 I think these options are workabout.
|
Doesn't look like it, but I think it makes sense.
The conclusion from further discussion here on this issue was that we'd start with adding this dropdown first, to see how that works for users. And that for discovery a more general getting started wizard might be more suitable. A wizard and a zero state placeholder are not mutually exclusive though, so I gave it a quick try in #3108 to see how it could work. Here's the result: (just a proof-of-concept; still WIP) |
@cathibosco Thoughts on this? There was also discussion that a placeholder on every empty Page might overload the interface. Probably especially for those who are not the first time users. Since most of the users from testing tried to add the background from the Image button, and now it's actually possible, then perhaps it makes sense to test it out first. (I'm not a UX specialist though.)
Agreed that it makes sense. |
FWIW, in my WIP PR the placeholder is only shown for the very first page when creating a new story. |
@spacedmonkey Could you address this in a new PR? That'd be great 🙂 |
That makes more sense. |
As originally discussed, the message was not to change. However, I go agree that this change makes sense. I think that the media picker as well should pre-select the existing image. I will open a new PR for this. |
@miina I think the placeholder is a great addition to the start state after doing some mock ups for #3067 Moving through the task of "set the background" - oh wait there are multiple backgrounds to set.. that feels confusing because we think of the background as one thing, the background. Visually bringing together the Background Color to the Background Media is one option test. (like @swissspidy 's example placeholder - which also brings Paragraph Block to the start state) In these mock ups I experimented with separating Background Media from a Color Layer (rather than telling an editor it is a "Background Color"). If an editor wishes to start with a Color Layer (we need to test the feasibility), the Background Media layer could be persistent as an editable Element. -this is similar to how Photoshop works for example. If an editor wants a background media - it is the first step and useful to have the screensaver. If an editor wants a Color Layer to start with - it covers the background media which lies in the background ready to be edited. Plus - the screen saver is potentially very useful for each page if it is a persistent element. |
I feel like this is a different piece of work than moving the media icon to the toolbar. I think we should open a new ticket and continue this discussion there. |
+1 |
@swissspidy See #3109 for updated wording. |
One small update to tests, after uploading an image from either the sidebar on toolbar, the wording of the toolbar should change insert to update background image / video. This is now merged and ready to test. |
Verified in QA |
Based on testing, most of the users struggle with adding background media to a Page, most of the users try to do it via adding an image block. Also, the place for adding Background Media doesn't seem to be obvious.
Some potential improvement ideas so far from discussion with @swissspidy:
Acceptance criteria based on backlog grooming, added by @MackenzieHartung on Aug 21:
As a user, I want an easier way to add background media to a page in my story.
AC1 - The existing image icon in the top tool bar will be the access point for a user to add media (video or image) to the page.
AC2 - If it is necessary for clarity, the icon can change to represent a broader media (video and image)
AC3 - When selecting the icon in the top tool bar the user will be presented with the option to add background image, inline image, background video and inline video.
AC4 - Selecting a specific option will take the user to the same location they would go today when making the selection to add background media or inline media today.
AC5 - Have the Background Color Panel open by default for the Page block.
The text was updated successfully, but these errors were encountered: