Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider listing background media in block navigation #2627

Closed
swissspidy opened this issue Jun 14, 2019 · 4 comments
Closed

Consider listing background media in block navigation #2627

swissspidy opened this issue Jun 14, 2019 · 4 comments
Labels
Discussion For issues that are high-level and not yet ready to implement. Enhancement New feature or improvement of an existing one Needs Testing Issues that need to be confirmed.

Comments

@swissspidy
Copy link
Collaborator

Screenshot:

Screen Shot 2019-06-13 at 5 09 32 PM

Related: #2564

@swissspidy swissspidy added Enhancement New feature or improvement of an existing one AMP Stories labels Jun 14, 2019
@miina
Copy link
Contributor

miina commented Jun 17, 2019

Maybe we should just rename the "elements" to "blocks"? The background image behaves quite differently and its order isn't changeable as in case of other blocks, not sure if it would make sense to add it to the block navigation separately. Are you thinking of adding this since otherwise, it's weird that there are no elements added but it shows a background image? In this case, it might be the same case for the background gradient as well. Not sure if either would make sense 🤷‍♀ Thoughts?

@swissspidy
Copy link
Collaborator Author

Note that we changed the naming from blocks to elements on purpose, see #2522.

IIRC I opened this issue here after some feedback from Alberto on Slack.

Personally I am still a bit on the fence about this possible enhancement. I guess we'd need some more user feedback here.

Are you thinking of adding this since otherwise, it's weird that there are no elements added but it shows a background image?

Yeah I think that is the reason.

In this case, it might be the same case for the background gradient as well.

Sticking with the elements terminology, I'd say an image is more of an element in that case than a gradient.

@miina
Copy link
Contributor

miina commented Jun 17, 2019

Sticking with the elements terminology, I'd say an image is more of an element in that case than a gradient.

Yep, I was thinking of that, too, but at the same time, the gradient has its own element, too (a grid layer).

I guess we'd need some more user feedback here.

That would be good 👍

@swissspidy
Copy link
Collaborator Author

Related: #2699

@swissspidy swissspidy added Discussion For issues that are high-level and not yet ready to implement. Needs Testing Issues that need to be confirmed. labels Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion For issues that are high-level and not yet ready to implement. Enhancement New feature or improvement of an existing one Needs Testing Issues that need to be confirmed.
Projects
None yet
Development

No branches or pull requests

3 participants