Skip to content

Commit

Permalink
Temp: Try removing object/page cache tests to see if E2E fixed
Browse files Browse the repository at this point in the history
  • Loading branch information
westonruter committed Jan 28, 2022
1 parent 4a4c490 commit d323217
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 21 deletions.
14 changes: 0 additions & 14 deletions src/Admin/SiteHealth.php
Original file line number Diff line number Diff line change
Expand Up @@ -180,11 +180,6 @@ public function register_async_test_endpoints() {
* @return array $tests The filtered tests, with tests for AMP.
*/
public function add_tests( $tests ) {
$tests['direct']['amp_persistent_object_cache'] = [
'label' => esc_html__( 'Persistent object cache', 'amp' ),
'test' => [ $this, 'persistent_object_cache' ],
];

if ( ! amp_is_canonical() && QueryVar::AMP !== amp_get_slug() ) {
$tests['direct']['amp_slug_definition_timing'] = [
'label' => esc_html__( 'AMP slug (query var) definition timing', 'amp' ),
Expand Down Expand Up @@ -212,15 +207,6 @@ public function add_tests( $tests ) {
'test' => [ $this, 'xdebug_extension' ],
];

if ( $this->supports_async_rest_tests( $tests ) ) {
$tests['async'][ self::TEST_PAGE_CACHING ] = [
'label' => esc_html__( 'Page caching', 'amp' ),
'test' => rest_url( self::REST_API_NAMESPACE . self::REST_API_PAGE_CACHE_ENDPOINT ),
'has_rest' => true,
'async_direct_test' => [ $this, 'page_cache' ],
];
}

return $tests;
}

Expand Down
7 changes: 0 additions & 7 deletions tests/php/src/Admin/SiteHealthTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -154,13 +154,6 @@ public function test_register_async_test_endpoints() {
public function test_add_tests() {
$tests = $this->instance->add_tests( [] );
$this->assertArrayHasKey( 'direct', $tests );
$this->assertArrayHasKey( 'amp_persistent_object_cache', $tests['direct'] );

if ( version_compare( get_bloginfo( 'version' ), '5.6', '>=' ) ) {
$this->assertArrayHasKey( 'amp_page_cache', $tests['async'] );
} elseif ( array_key_exists( 'async', $tests ) ) {
$this->assertArrayNotHasKey( 'amp_page_cache', $tests['async'] );
}

$this->assertArrayHasKey( 'amp_curl_multi_functions', $tests['direct'] );
$this->assertArrayNotHasKey( 'amp_icu_version', $tests['direct'] );
Expand Down

0 comments on commit d323217

Please sign in to comment.