Improve preload handling with runtime self hosting #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove v0.js preloads if esm mode is enabled (the esm modules should be preloaded instead) * rename existing v0.js preloads
sebastianbenz
force-pushed
the
rewrite-preload
branch
from
daf4fe7
to
2a69d05
Compare
patrickkettner
approved these changes
Jul 7, 2020
| } | ||
| node = node.nextSibling; | ||
| } | ||
|
|
||
| // process preloads later to avoid accidently rewriting the URL | ||
| for (const preload of preloads) { | ||
| if (preload) { |
There was a problem hiding this comment.
when would this be false?
There was a problem hiding this comment.
Some scripts should not have a preload. In that case rewrite URL returns null.
|
Thanks for the review |
tharders
pushed a commit
that referenced
this pull request
Aug 17, 2020
* remove v0.js preloads if esm mode is enabled (the esm modules should be preloaded instead) * rename existing v0.js preloads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
be preloaded instead)