Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Refactor icon font detection #1153

Merged
merged 5 commits into from
Mar 2, 2021
Merged

♻️ Refactor icon font detection #1153

merged 5 commits into from
Mar 2, 2021

Conversation

lluerich
Copy link
Collaborator

@lluerich lluerich commented Mar 2, 2021

  • uses list of grouped parameters
  • fixes postcss-8 deprecation warning

sebastianbenz
sebastianbenz approved these changes Mar 2, 2021
View reviewed changes
Copy link
Collaborator

@sebastianbenz sebastianbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests for the new logic?

@sebastianbenz sebastianbenz merged commit bd0dec5 into ampproject:main Mar 2, 2021
@lluerich lluerich mentioned this pull request Mar 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastianbenz sebastianbenz sebastianbenz approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lluerich @sebastianbenz