Remove for-in loop on array #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…numerable properties
|
Please merge this PR as this problem has already causing some of our user using a lower version of Android Webview with our App to crash due to an issue described in amplitude/Amplitude-JavaScript#435. In-house solution was to create a patch using |
|
@qingzhuozhen - could you please review this PR? or refresh the fork from upstream? This bug has been addressed in the upstream |
|
Hey @jooohhn, any chance you can help move this one along? |
|
@jooohhn - any ETA on when we could expect for this to be pulled into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there, I'm trying to load
amplitude-jsinto a browser context that also has some third party scripts that we can't control. One such script is modifying the Array prototype and adding additional enumerable properties.These additional properties are picked up by the for-in loop in
enumerizeand result in the evaluation oftoUpperCaseon potentially non-string values, causing a crash.Replacing the for-in loop with a counter based for loop would make this safer.