Fix generic defaulting w/ middleware types #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Need to put the `TEntities` first in the generic parameters, so the action generic type can be defaulted properly.
4 tasks
rctbusk
reviewed
Oct 30, 2019
| @@ -254,7 +254,7 @@ declare module 'redux-query' { | |||
| }; | |||
|
|
|||
| export const queryMiddleware: QueryMiddlewareFactory; | |||
| export interface ReduxQueryDispatch<A extends AnyAction = ReduxQueryAction<TEntities>, TEntities = Entities> { | |||
| export interface ReduxQueryDispatch<TEntities = Entities, A extends AnyAction = ReduxQueryAction<TEntities>> { | |||
There was a problem hiding this comment.
Why the change in order here?
There was a problem hiding this comment.
Otherwise you get this errror:
node_modules/redux-query/index.d.ts:257:78 - error TS2744: Type parameter defaults can only reference previously declared type parameters.
257 export interface ReduxQueryDispatch<A extends AnyAction = ReduxQueryAction, TEntities = Entities> {
See also OpenAPITools/openapi-generator#3824
|
@rctbusk Thanks for merging this! Any chance we can get a 3.2.1 release that publishes this? |
|
Yep! Working on testing the patch now |
|
I have published an alpha release and am testing it now. https://www.npmjs.com/package/redux-query |
|
A full version (3.2.1) should be published now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TEntitiesfirst in the generic parameters,so the action generic type can be defaulted properly.