fix: fix os version #430
Merged
fix: fix os version #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuyang1520
reviewed
Mar 8, 2023
liuyang1520
approved these changes
Mar 8, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Mar 8, 2023
## [8.15.2](v8.15.1...v8.15.2) (2023-03-08) ### Bug Fixes * fix os version ([#430](#430)) ([23fcf7d](23fcf7d))
|
🎉 This PR is included in version 8.15.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the fix for https://amplitude.atlassian.net/browse/DXOC-526?focusedCommentId=169089
TARGET_OS_MACCATALYST is the iPad app that runs on MacOS. Based on the previous logic, the os version will be the iOS version. It makes sense to use the mac version for the os version for this case. Otherwise, the os will be
macos 15.0which is not a valid macOS version. Check here for how the current os version looks like https://analytics.amplitude.com/linearity/chart/6db6un2/edit/us3pssm.With these changes, the TARGET_OS_MACCATALYST will fall into checking the mac os version instead.
Checklist