Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose more logEvent function signature #409

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Conversation

yuhao900914
Copy link
Contributor

@yuhao900914 yuhao900914 commented Aug 9, 2022

Summary

Customers need to call clearAll followed with set identify calls.
But SDK logic is ignore all identify call after the clearAll operations
Provided this as a workaround to let the customer do:

    NSMutableDictionary *userProperties = [NSMutableDictionary dictionary];
    [userProperties setValue:@"-" forKey:@"$clearAll"];
    NSMutableDictionary *setOpProperties = [NSMutableDictionary dictionary];
    [setOpProperties setValue:@"value1" forKey:@"prop1"];
    
    [userProperties setObject:setOpProperties forKey:@"$set"];

    [[Amplitude instance] logEvent:@"$identify" withEventProperties:nil withUserProperties: userProperties ];

For more reference:
https://amplitude.atlassian.net/browse/DXOC-44

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

@yuhao900914 yuhao900914 marked this pull request as draft August 9, 2022 07:05
@yuhao900914 yuhao900914 changed the title Improvement feat: expose more logEvent functions Aug 9, 2022
@yuhao900914 yuhao900914 force-pushed the improvement branch 2 times, most recently from f70d032 to c1b26a5 Compare August 9, 2022 08:17
@yuhao900914 yuhao900914 changed the title feat: expose more logEvent functions feat: expose more logEvent function signature Aug 9, 2022
@yuhao900914 yuhao900914 marked this pull request as ready for review August 9, 2022 08:25
Podfile.lock Outdated Show resolved Hide resolved
@yuhao900914 yuhao900914 merged commit c6195f8 into main Aug 10, 2022
@yuhao900914 yuhao900914 deleted the improvement branch August 10, 2022 21:15
github-actions bot pushed a commit that referenced this pull request Aug 10, 2022
# [8.12.0](v8.11.1...v8.12.0) (2022-08-10)

### Features

* expose more function signature for logEvent ([#409](#409)) ([c6195f8](c6195f8))
@github-actions
Copy link

🎉 This PR is included in version 8.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

junjie added a commit to junjie/Amplitude-iOS that referenced this pull request Sep 6, 2022
…entify-object

* commit 'f07749967fb8e628f9f2c743fab2ba6600574d85':
  chore(release): 8.12.0 [skip ci]
  feat: expose more function signature for logEvent (amplitude#409)
  chore: use the reusable workflow to create jira issue (amplitude#408)
  chore(release): 8.11.1 [skip ci]
  fix: turn requiringSecureCoding on, adjust the available version (amplitude#407)
  chore(release): 8.11.0 [skip ci]
  fix: deprecation fix (amplitude#404)
  feat: add EU SSL pinning cert, extent it to support multiple domains (amplitude#403)
  chore(release): 8.10.2 [skip ci]
  Revert "Compile with code coverage enabled (amplitude#398)" (amplitude#402)
  chore(release): 8.10.1 [skip ci]
  fix: wrong carrier info with deprecated method (amplitude#400)
  Compile with code coverage enabled (amplitude#398)
  chore(release): 8.10.0 [skip ci]
  feat: Add versionId to tracking plan data (amplitude#392)
  chore(release): 8.9.0 [skip ci]
  fix: fix release action
  Update Podfile.lock
  feat: Add support on Swift Package Manager for WatchOS (amplitude#381)
  docs: add Ampli SDK reference (amplitude#385)

# Conflicts:
#	Sources/Amplitude/AMPURLSession.m
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants