Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix umbrella header warning #346

Merged
merged 1 commit into from
Apr 30, 2021
Merged

fix: fix umbrella header warning #346

merged 1 commit into from
Apr 30, 2021

Conversation

yuhao900914
Copy link
Contributor

Summary

Fix umbrella header warning when install SDK using SPM.
Temporary make Amplitude+SSLPinning.h as a private header for people who install SDK usingSPM

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: no

jooohhn
jooohhn reviewed Apr 30, 2021
View reviewed changes
Copy link
Contributor

@jooohhn jooohhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be a breaking change if we make Amplitude+SSLPinning.h private? Otherwise LGTM 👍

@yuhao900914 yuhao900914 reopened this Apr 30, 2021
@yuhao900914 yuhao900914 merged commit f5d10f7 into main Apr 30, 2021
@yuhao900914 yuhao900914 deleted the AMP-35388 branch April 30, 2021 16:21
github-actions bot pushed a commit that referenced this pull request Apr 30, 2021
@amplitude-sdk-bot
chore(release): 8.3.0 [skip ci]
68eea81 
# [8.3.0](v8.2.1...v8.3.0) (2021-04-30)

### Bug Fixes

* fix umbrella header warning ([#346](#346)) ([f5d10f7](f5d10f7))

### Features

* Add preInsert, postInsert and remove functions to Identify and Group Identify ([#338](#338)) ([4cc28bf](4cc28bf))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jooohhn jooohhn jooohhn left review comments

@haoliu-amp haoliu-amp haoliu-amp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuhao900914 @jooohhn @haoliu-amp