fix: skip deep link event when url is missing (#150)

amplitude · Oct 16, 2023 · b8a4a87 · b8a4a87
1 parent 90ef21c
commit b8a4a87
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 8 deletions.
diff --git a/android/src/main/java/com/amplitude/android/utilities/DefaultEventUtils.kt b/android/src/main/java/com/amplitude/android/utilities/DefaultEventUtils.kt
@@ -91,14 +91,16 @@ class DefaultEventUtils(private val amplitude: Amplitude) {
         val intent = activity.intent
         intent?.let {
             val referrer = getReferrer(activity)?.toString()
-            val url = it.data?.toString()
-            amplitude.track(
-                EventTypes.DEEP_LINK_OPENED,
-                mapOf(
-                    EventProperties.LINK_URL to url,
-                    EventProperties.LINK_REFERRER to referrer,
-                ),
-            )
+            it.data?.let { uri ->
+                val url = uri.toString()
+                amplitude.track(
+                    EventTypes.DEEP_LINK_OPENED,
+                    mapOf(
+                        EventProperties.LINK_URL to url,
+                        EventProperties.LINK_REFERRER to referrer,
+                    ),
+                )
+            }
         }
     }
 

diff --git a/android/src/test/java/com/amplitude/android/plugins/AndroidLifecyclePluginTest.kt b/android/src/test/java/com/amplitude/android/plugins/AndroidLifecyclePluginTest.kt
@@ -496,4 +496,30 @@ class AndroidLifecyclePluginTest {
         verify(exactly = 0) { mockedPlugin.track(capture(tracks)) }
         Assertions.assertEquals(0, tracks.count())
     }
+
+    @Test
+    fun `test deep link opened event is not tracked when URL is missing`() = runTest {
+        setDispatcher(testScheduler)
+        configuration.defaultTracking.deepLinks = true
+        amplitude.add(androidLifecyclePlugin)
+
+        val mockedPlugin = spyk(StubPlugin())
+        amplitude.add(mockedPlugin)
+        amplitude.isBuilt.await()
+
+        val mockedIntent = mockk<Intent>()
+        every { mockedIntent.data } returns null
+        val mockedActivity = mockk<Activity>()
+        every { mockedActivity.intent } returns mockedIntent
+        every { mockedActivity.referrer } returns Uri.parse("android-app://com.android.unit-test")
+        val mockedBundle = mockk<Bundle>()
+        androidLifecyclePlugin.onActivityCreated(mockedActivity, mockedBundle)
+
+        advanceUntilIdle()
+        Thread.sleep(100)
+
+        val tracks = mutableListOf<BaseEvent>()
+        verify(exactly = 0) { mockedPlugin.track(capture(tracks)) }
+        Assertions.assertEquals(0, tracks.count())
+    }
 }