Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix s3 upload script to use iam role #534

Merged
merged 2 commits into from
May 31, 2022
Merged

fix: fix s3 upload script to use iam role #534

merged 2 commits into from
May 31, 2022

Conversation

kevinpagtakhan
Copy link
Contributor

Summary

Fix s3 script to use default aws config associated with an iam role. Access key and secret access key are no longer available to use. We use aws-actions/configure-aws-credentials@v1 to auth with an iam role. Github actions will assume github-actions-role and perform api actions the role has been granted to.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

@kevinpagtakhan kevinpagtakhan self-assigned this May 12, 2022
@kevinpagtakhan kevinpagtakhan changed the title Fix s3 upload script fix: fix s3 upload script to use iam role May 12, 2022
@kevinpagtakhan kevinpagtakhan merged commit a453dc3 into main May 31, 2022
@kevinpagtakhan kevinpagtakhan deleted the fix-s3-upload-script branch May 31, 2022 21:14
github-actions bot pushed a commit that referenced this pull request Jun 24, 2022
@amplitude-sdk-bot
chore(release): 8.18.5 [skip ci]
27b4957 
## [8.18.5](v8.18.4...v8.18.5) (2022-06-24)

### Bug Fixes

* add guard for navigator for use in envs that do no support navigator ([#542](#542)) ([c3b31ad](c3b31ad))
* fix s3 upload script to use iam role ([#534](#534)) ([a453dc3](a453dc3))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingzhuozhen qingzhuozhen qingzhuozhen approved these changes

@yuhao900914 yuhao900914 yuhao900914 approved these changes

@dnshi dnshi dnshi approved these changes

Assignees

@kevinpagtakhan kevinpagtakhan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevinpagtakhan @dnshi @yuhao900914 @qingzhuozhen