Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(initialization): always return this in onInit #300

Merged
merged 1 commit into from
Sep 22, 2020
Merged

fix(initialization): always return this in onInit #300

merged 1 commit into from
Sep 22, 2020

Conversation

kelvin-lu
Copy link
Contributor

@kelvin-lu kelvin-lu commented Sep 22, 2020 •
edited
Loading

Summary

This PR adds this as the argument for onInit every time it is called (or really, adding it to a single place where it wasn't being sent) - this guarantees that the user always has a safe and full Amplitude object when onInit is called.

Checklist

  • Does your PR title have the correct title format
  • Does your PR have a breaking change?

@kelvin-lu kelvin-lu merged commit 44d00d7 into master Sep 22, 2020
@kelvin-lu kelvin-lu deleted the 273/on-init branch September 22, 2020 19:48
github-actions bot pushed a commit that referenced this pull request Sep 22, 2020
@semantic-release-bot
chore(release): 7.2.1 [skip ci]
bec6e50 
## [7.2.1](v7.2.0...v7.2.1) (2020-09-22)

### Bug Fixes

* **initialization:** always return `this` in onInit ([#300](#300)) ([44d00d7](44d00d7))
* move bad postinstall script ([#301](#301)) ([ca98af3](ca98af3))
@github-actions
Copy link

🎉 This PR is included in version 7.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haoliu-amp haoliu-amp haoliu-amp approved these changes

@jooohhn jooohhn jooohhn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kelvin-lu @jooohhn @haoliu-amp