-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/36 control flow implementation #44
Conversation
Overview over possible features we want to add to our Base Data Collector (BDC)
Signed-off-by: Berkay Bozkurt <resitberkaybozkurt@gmail.com>
…ed some dummy data for example purposes. #22 Signed-off-by: Felix Zailskas <felixzailskas@gmail.com>
Signed-off-by: Ahmed Sheta <ahmed.sheta@fau.de>
Signed-off-by: Ahmed Sheta <ahmed.sheta@fau.de>
--------- Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de>
Fix the logo so that only the correct version (dark / light) gets displayed.
The dynamic media source was still not working, but now it should
…lidation to Lead object Signed-off-by: Felix Zailskas <felixzailskas@gmail.com>
Signed-off-by: Felix Zailskas <felixzailskas@gmail.com>
…n each execution with dummy data. Signed-off-by: Felix Zailskas <felixzailskas@gmail.com>
* add pipfile.lock, make pipenv install verbose Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de> * enable caching pipenv deps in pipeline Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de> * check if moving the test file fixes it Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de> * add __init__.py to tests folder Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de> * refactor test Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de> * refactor test Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de> * add all dev deps to Pipfile Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de> * add all dev deps to Pipfile Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de> * add all dev deps to Pipfile Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de> * minor changes to pipeline Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de> * minor changes to pipeline Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de> --------- Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de>
Signed-off-by: Felix Zailskas <felixzailskas@gmail.com>
Signed-off-by: Berkay Bozkurt <resitberkaybozkurt@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good implementation. I added some small comments that we might want to adjust
Signed-off-by: Berkay Bozkurt <resitberkaybozkurt@gmail.com>
Signed-off-by: Berkay Bozkurt <resitberkaybozkurt@gmail.com>
Signed-off-by: Berkay Bozkurt <resitberkaybozkurt@gmail.com>
Signed-off-by: Berkay Bozkurt <resitberkaybozkurt@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small stuff regarding pydantic.
Signed-off-by: Berkay Bozkurt <resitberkaybozkurt@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good.
…tation Feature/36 control flow implementation
Controller implementation skeleton, to provide async, thread-safe communication between EVP and BDC.
Example usage for BDC :
controller = Controller()
lead_id = 2023
message = create_data_message(lead_id, {"features1: feature1, “features2“: feature2 , ...})
controller.send_message(message)
Example usage for EVP :
controller = Controller()
lead_id = 2023
prediction_value = 0.8
message = create_prediction_message(lead_id, prediction_value
controller.send_message(message)