Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/36 control flow implementation #44

Merged
merged 19 commits into from
Nov 7, 2023

Conversation

rbbozkurt
Copy link
Contributor

Controller implementation skeleton, to provide async, thread-safe communication between EVP and BDC.

Example usage for BDC :

controller = Controller()
lead_id = 2023
message = create_data_message(lead_id, {"features1: feature1, “features2“: feature2 , ...})
controller.send_message(message)

Example usage for EVP :

controller = Controller()
lead_id = 2023
prediction_value = 0.8
message = create_prediction_message(lead_id, prediction_value
controller.send_message(message)

ur-tech and others added 14 commits October 27, 2023 16:34
Overview over possible features we want to add to our Base Data Collector (BDC)
Signed-off-by: Berkay Bozkurt <resitberkaybozkurt@gmail.com>
…ed some dummy data for example purposes. #22

Signed-off-by: Felix Zailskas <felixzailskas@gmail.com>
Signed-off-by: Ahmed Sheta <ahmed.sheta@fau.de>
Signed-off-by: Ahmed Sheta <ahmed.sheta@fau.de>
---------

Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de>
Fix the logo so that only the correct version (dark / light) gets displayed.
The dynamic media source was still not working, but now it should
…lidation to Lead object

Signed-off-by: Felix Zailskas <felixzailskas@gmail.com>
Signed-off-by: Felix Zailskas <felixzailskas@gmail.com>
…n each execution with dummy data.

Signed-off-by: Felix Zailskas <felixzailskas@gmail.com>
* add pipfile.lock, make pipenv install verbose

Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de>

* enable caching pipenv deps in pipeline

Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de>

* check if moving the test file fixes it

Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de>

* add __init__.py to tests folder

Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de>

* refactor test

Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de>

* refactor test

Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de>

* add all dev deps to Pipfile

Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de>

* add all dev deps to Pipfile

Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de>

* add all dev deps to Pipfile

Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de>

* minor changes to pipeline

Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de>

* minor changes to pipeline

Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de>

---------

Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de>
Signed-off-by: Felix Zailskas <felixzailskas@gmail.com>
Signed-off-by: Berkay Bozkurt <resitberkaybozkurt@gmail.com>
@rbbozkurt rbbozkurt requested review from felix-zailskas and ruchita-nathani and removed request for felix-zailskas November 5, 2023 17:39
Copy link
Contributor

@felix-zailskas felix-zailskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good implementation. I added some small comments that we might want to adjust

src/controller/messenger.py Outdated Show resolved Hide resolved
src/controller/Controller.py Outdated Show resolved Hide resolved
src/controller/Controller.py Outdated Show resolved Hide resolved
src/controller/messenger.py Outdated Show resolved Hide resolved
Signed-off-by: Berkay Bozkurt <resitberkaybozkurt@gmail.com>
Signed-off-by: Berkay Bozkurt <resitberkaybozkurt@gmail.com>
Signed-off-by: Berkay Bozkurt <resitberkaybozkurt@gmail.com>
Signed-off-by: Berkay Bozkurt <resitberkaybozkurt@gmail.com>
Copy link
Contributor

@felix-zailskas felix-zailskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small stuff regarding pydantic.

src/controller/messenger.py Outdated Show resolved Hide resolved
src/controller/messenger.py Outdated Show resolved Hide resolved
Signed-off-by: Berkay Bozkurt <resitberkaybozkurt@gmail.com>
Copy link
Contributor

@felix-zailskas felix-zailskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@ruchita-nathani ruchita-nathani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good.

@rbbozkurt rbbozkurt merged commit 6ce7aa2 into dev Nov 7, 2023
4 checks passed
@Tims777 Tims777 deleted the feature/36-control-flow-implementation branch November 8, 2023 11:15
@Tims777 Tims777 linked an issue Nov 15, 2023 that may be closed by this pull request
luccalb pushed a commit that referenced this pull request Jan 23, 2024
…tation

Feature/36 control flow implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Controller skeleton
7 participants