generated from amosproj/amos202Xss0Y-projname
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/235 all steps bdc errors #239
Merged
Merged
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a20c71d
fix minor error in regionalatlas step + moved scrape address step to …
luccalb e228a82
undo change to input filename
luccalb ce0140f
Adjust gpt caching error logging
luccalb 67ddaaa
change input file location back to original
luccalb e0387c1
Merge branch 'dev' into bugfix/235-all-steps-bdc-errors
luccalb 4977ae7
Add explanation for deprecation of scrape_addresses.py
luccalb 302136c
Adjust error logging for review analysis
luccalb 1da8c3e
Merge branch 'dev' into bugfix/235-all-steps-bdc-errors
luccalb 91b83ae
remove deprecated steps from tests
luccalb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
{ | ||
"description": "This config runs all steps with force_refresh set to true.", | ||
"config": { | ||
"steps": [ | ||
{ | ||
"name": "HashGenerator", | ||
"force_refresh": true | ||
}, | ||
{ | ||
"name": "AnalyzeEmails", | ||
"force_refresh": true | ||
}, | ||
{ | ||
"name": "PreprocessPhonenumbers", | ||
"force_refresh": true | ||
}, | ||
{ | ||
"name": "GooglePlaces", | ||
"force_refresh": true | ||
}, | ||
{ | ||
"name": "GooglePlacesDetailed", | ||
"force_refresh": true | ||
}, | ||
{ | ||
"name": "GPTReviewSentimentAnalyzer", | ||
"force_refresh": true | ||
}, | ||
{ | ||
"name": "GPTSummarizer", | ||
"force_refresh": true | ||
}, | ||
{ | ||
"name": "SmartReviewInsightsEnhancer", | ||
"force_refresh": true | ||
}, | ||
{ | ||
"name": "RegionalAtlas", | ||
"force_refresh": true | ||
} | ||
] | ||
} | ||
} |
2 changes: 2 additions & 0 deletions
2
src/demo/pipeline_configs/force_refresh_all_steps.json.license
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
SPDX-License-Identifier: MIT | ||
SPDX-FileCopyrightText: 2023 Berkay Bozkurt <resitberkaybozkurt@gmail.com> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
{ | ||
"description": "This config runs all steps with force_refresh set to true.", | ||
"config": { | ||
"steps": [ | ||
{ | ||
"name": "HashGenerator", | ||
"force_refresh": true | ||
}, | ||
{ | ||
"name": "AnalyzeEmails", | ||
"force_refresh": true | ||
}, | ||
{ | ||
"name": "PreprocessPhonenumbers", | ||
"force_refresh": true | ||
}, | ||
{ | ||
"name": "GooglePlaces", | ||
"force_refresh": true | ||
}, | ||
{ | ||
"name": "RegionalAtlas", | ||
"force_refresh": true | ||
} | ||
] | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
SPDX-License-Identifier: MIT | ||
SPDX-FileCopyrightText: 2023 Lucca Baumgärtner <lucca.baumgaertner@fau.de> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need force_refresh on all the earlier steps if we only want to run RegionalAtlas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depends if you expect that there can be newer data found than what you have locally. I don't expect the addresses to change much and the regionalatlas data is local anyway so it cant change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In any case, it's ensured that the data is present, it's just not refreshed :)